Change in coreboot[master]: drivers/intel/fsp/Makefile: warn when FSP files aren't specified - coreboot-gerrit

1 Sep 2021


      Attention is currently required from: Nico Huber, Andrey Petrov, Patrick Rudolph, Felix Held.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57219 )
Change subject: drivers/intel/fsp/Makefile: warn when FSP files aren't specified
......................................................................
Patch Set 1: Code-Review+2
(3 comments)
File src/drivers/intel/fsp2_0/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/57219/comment/abbae5aa_6e50fcec 
PS1, Line 101: CONFIG_FSP_T_FILE
...
CB:57220 […]
Ack
https://review.coreboot.org/c/coreboot/+/57219/comment/d255c082_2f73a4ea 
PS1, Line 102: warning
...
wasn't sure if this will break some case, so i made this print a warning and not throw an error
It might make sense to make this an error. If ADD_FSP_BINARIES are set and the files are not provided, then it is an invalid condition.
https://review.coreboot.org/c/coreboot/+/57219/comment/2de18c4a_aad2c3fb 
PS1, Line 105: $(call strip_quotes,$(CONFIG_FSP_M_FILE))
...
no, FSP_M_CBFS is the result of calling strip_quotes on CONFIG_FSP_M_CBFS, not CONFIG_FSP_M_FILE
Ack.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/57219
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie5f2d75d066f0b4e491e9c8420b7a0cbd4ba9e28
Gerrit-Change-Number: 57219
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Andrey Petrov andrey.petrov@gmail.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Andrey Petrov andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 02 Sep 2021 02:52:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment