Change in coreboot[master]: mb/google/zork: Drop unused function variant_romstage_entry()
Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43116 )
Change subject: mb/google/zork: Drop unused function variant_romstage_entry() ......................................................................
mb/google/zork: Drop unused function variant_romstage_entry()
This change drops the function `variant_romstage_entry()` which is unused on zork.
Change-Id: I140ab3e837971c4c7dbef5d27616043b5fc6c2c9 Signed-off-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/zork/romstage.c M src/mainboard/google/zork/variants/baseboard/include/baseboard/variants.h 2 files changed, 0 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/43116/1
diff --git a/src/mainboard/google/zork/romstage.c b/src/mainboard/google/zork/romstage.c index 9d7b850..3da8a53 100644 --- a/src/mainboard/google/zork/romstage.c +++ b/src/mainboard/google/zork/romstage.c @@ -8,11 +8,6 @@ #include <variant/ec.h> #include <console/console.h>
-void __weak variant_romstage_entry(void) -{ - /* By default, don't do anything */ -} - void mainboard_romstage_entry_s3(int s3_resume) { size_t num_gpios; @@ -23,6 +18,4 @@ variant_pcie_power_reset_configure();
mainboard_ec_init(); - - variant_romstage_entry(); } diff --git a/src/mainboard/google/zork/variants/baseboard/include/baseboard/variants.h b/src/mainboard/google/zork/variants/baseboard/include/baseboard/variants.h index c3986bc..ac29b92 100644 --- a/src/mainboard/google/zork/variants/baseboard/include/baseboard/variants.h +++ b/src/mainboard/google/zork/variants/baseboard/include/baseboard/variants.h @@ -32,7 +32,6 @@ */ const struct soc_amd_gpio *variant_sleep_gpio_table(size_t *size, int slp_typ);
-void variant_romstage_entry(void); /* Modify devictree settings during ramstage. */ void variant_devtree_update(void); /* Update audio configuration in devicetree during ramstage. */
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43116 )
Change subject: mb/google/zork: Drop unused function variant_romstage_entry() ......................................................................
Patch Set 1: Code-Review+2
Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43116 )
Change subject: mb/google/zork: Drop unused function variant_romstage_entry() ......................................................................
mb/google/zork: Drop unused function variant_romstage_entry()
This change drops the function `variant_romstage_entry()` which is unused on zork.
Change-Id: I140ab3e837971c4c7dbef5d27616043b5fc6c2c9 Signed-off-by: Furquan Shaikh furquan@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/43116 Reviewed-by: Aaron Durbin adurbin@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/zork/romstage.c M src/mainboard/google/zork/variants/baseboard/include/baseboard/variants.h 2 files changed, 0 insertions(+), 8 deletions(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved
diff --git a/src/mainboard/google/zork/romstage.c b/src/mainboard/google/zork/romstage.c index 9d7b850..3da8a53 100644 --- a/src/mainboard/google/zork/romstage.c +++ b/src/mainboard/google/zork/romstage.c @@ -8,11 +8,6 @@ #include <variant/ec.h> #include <console/console.h>
-void __weak variant_romstage_entry(void) -{ - /* By default, don't do anything */ -} - void mainboard_romstage_entry_s3(int s3_resume) { size_t num_gpios; @@ -23,6 +18,4 @@ variant_pcie_power_reset_configure();
mainboard_ec_init(); - - variant_romstage_entry(); } diff --git a/src/mainboard/google/zork/variants/baseboard/include/baseboard/variants.h b/src/mainboard/google/zork/variants/baseboard/include/baseboard/variants.h index c3986bc..ac29b92 100644 --- a/src/mainboard/google/zork/variants/baseboard/include/baseboard/variants.h +++ b/src/mainboard/google/zork/variants/baseboard/include/baseboard/variants.h @@ -32,7 +32,6 @@ */ const struct soc_amd_gpio *variant_sleep_gpio_table(size_t *size, int slp_typ);
-void variant_romstage_entry(void); /* Modify devictree settings during ramstage. */ void variant_devtree_update(void); /* Update audio configuration in devicetree during ramstage. */
-
Aaron Durbin (Code Review) -
Furquan Shaikh (Code Review)