Change in coreboot[master]: mb/google/volteer: Define stop_gpio for goodix touch screen

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44356 )

Change subject: mb/google/volteer: Define stop_gpio for goodix touch screen
......................................................................

mb/google/volteer: Define stop_gpio for goodix touch screen

This applies to the goodix touch screen on both the volteer and
volteer2 variants: Define GPP_E3 as the stop_gpio for the touch screen
"Report_Switch" signal. Goodix defines a 1ms (minimum) delay after
stop off. In addition, no longer drive this GPIO high by default as it
is now controlled by the kernel through ACPI.

BUG=b:153705232
TEST=touch screen still functional on volteer; confirmed timings with
    scope (VDD, RESET, REPORT_SWITCH)

Change-Id: I3ead9cf79812d08c4917be4585ed273050465a9b
Signed-off-by: Caveh Jalali 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44356
Tested-by: build bot (Jenkins) 
Reviewed-by: Tim Wawrzynczak 
---
M src/mainboard/google/volteer/variants/volteer/gpio.c
M src/mainboard/google/volteer/variants/volteer/overridetree.cb
M src/mainboard/google/volteer/variants/volteer2/gpio.c
M src/mainboard/google/volteer/variants/volteer2/overridetree.cb
4 files changed, 14 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Tim Wawrzynczak: Looks good to me, approved

diff --git a/src/mainboard/google/volteer/variants/volteer/gpio.c b/src/mainboard/google/volteer/variants/volteer/gpio.c
index 8bbc447..df17e50 100644
--- a/src/mainboard/google/volteer/variants/volteer/gpio.c
+++ b/src/mainboard/google/volteer/variants/volteer/gpio.c
@@ -102,7 +102,7 @@
    /* E2  : SPI1_IO3 ==> WLAN_PCIE_WAKE_ODL */
    PAD_CFG_GPI(GPP_E2, NONE, DEEP),
    /* E3  : CPU_GP0 ==> USI_REPORT_EN */
-	PAD_CFG_GPO(GPP_E3, 1, DEEP),
+	PAD_CFG_GPO(GPP_E3, 0, DEEP),
    /* E7  : CPU_GP1 ==> USI_INT */
    PAD_CFG_GPI_APIC(GPP_E7, NONE, PLTRST, LEVEL, NONE),
    /* E8  : SPI1_CS1# ==> SLP_S0IX */
diff --git a/src/mainboard/google/volteer/variants/volteer/overridetree.cb b/src/mainboard/google/volteer/variants/volteer/overridetree.cb
index d4bd7f4..a435c95 100644
--- a/src/mainboard/google/volteer/variants/volteer/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/volteer/overridetree.cb
@@ -89,10 +89,16 @@
    			register "generic.probed" = "1"
    			register "generic.reset_gpio" =
    						"ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C10)"
+				# Parameter T3 >= 10ms
    			register "generic.reset_delay_ms" = "120"
+				# Parameter T2 >= 1ms
    			register "generic.reset_off_delay_ms" = "3"
    			register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_A8)"
+				# Parameter T1 >= 10ms
    			register "generic.enable_delay_ms" = "12"
+				register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_E3)"
+				# Parameter T4 >= 1ms
+				register "generic.stop_off_delay_ms" = "1"
    			register "generic.has_power_resource" = "1"
    			register "hid_desc_reg_offset" = "0x01"
    			device i2c 14 on end
diff --git a/src/mainboard/google/volteer/variants/volteer2/gpio.c b/src/mainboard/google/volteer/variants/volteer2/gpio.c
index 96d940a..09a4dd5 100644
--- a/src/mainboard/google/volteer/variants/volteer2/gpio.c
+++ b/src/mainboard/google/volteer/variants/volteer2/gpio.c
@@ -102,7 +102,7 @@
    /* E2  : SPI1_IO3 ==> WLAN_PCIE_WAKE_ODL */
    PAD_CFG_GPI(GPP_E2, NONE, DEEP),
    /* E3  : CPU_GP0 ==> USI_REPORT_EN */
-	PAD_CFG_GPO(GPP_E3, 1, DEEP),
+	PAD_CFG_GPO(GPP_E3, 0, DEEP),
    /* E7  : CPU_GP1 ==> USI_INT */
    PAD_CFG_GPI_APIC(GPP_E7, NONE, PLTRST, LEVEL, NONE),
    /* E8  : SPI1_CS1# ==> SLP_S0IX */
diff --git a/src/mainboard/google/volteer/variants/volteer2/overridetree.cb b/src/mainboard/google/volteer/variants/volteer2/overridetree.cb
index 62749fc..fefe9ba 100644
--- a/src/mainboard/google/volteer/variants/volteer2/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/volteer2/overridetree.cb
@@ -45,10 +45,16 @@
    			register "generic.probed" = "1"
    			register "generic.reset_gpio" =
    						"ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C10)"
+				# Parameter T3 >= 10ms
    			register "generic.reset_delay_ms" = "120"
+				# Parameter T2 >= 1ms
    			register "generic.reset_off_delay_ms" = "3"
    			register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_A8)"
+				# Parameter T1 >= 10ms
    			register "generic.enable_delay_ms" = "12"
+				register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_E3)"
+				# Parameter T4 >= 1ms
+				register "generic.stop_off_delay_ms" = "1"
    			register "generic.has_power_resource" = "1"
    			register "hid_desc_reg_offset" = "0x01"
    			device i2c 14 on end