Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Michael Niewöhner, Angel Pons, Patrick Rudolph, Karthik Ramasubramanian. Cliff Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56004 )
Change subject: soc/intel/common/block/acpi: Move pep.asl to acpigen ......................................................................
Patch Set 1:
(2 comments)
File src/soc/intel/common/block/acpi/Kconfig:
https://review.coreboot.org/c/coreboot/+/56004/comment/25748aa5_50b92bad PS1, Line 18: config SOC_INTEL_COMMON_BLOCK_ACPI_PEP When this is set, the only change is to include pep.c in the build. Not clear what is the requirement, such as generate_acpi_power_engine() needs to be called at the mainboard.
pep.asl is still used for the older platform (included southbridge.asl). One good thing is that we can leave those older platforms intact. But, not having this flag set does not really means that we disable it. Perhaps, just change the name a bit to reflect what it is providing.
File src/soc/intel/common/block/include/intelblocks/acpi.h:
https://review.coreboot.org/c/coreboot/+/56004/comment/f902717a_553ad079 PS1, Line 94: void generate_acpi_power_engine(const struct device *dev); Please add #if CONFIG(CONFIG_SOC_INTEL_COMMON_BLOCK_ACPI_PEP) for this declaration.
-
Cliff Huang (Code Review)