Nicola Corna has posted comments on this change. ( https://review.coreboot.org/19257 )
Change subject: sb/intel/common/firmware: Keep CHECK_ME disabled by default ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/19257/1//COMMIT_MSG Commit Message:
PS1, Line 9: Keeping CHECK_ME unset by default.
IMO this option is only useful if people are messing with their ME binary.
with the -c flag the ME binary is opened in read-only mode, and it just checks the presence of the fundamental parts of the ME image https://github.com/corna/me_cleaner/blob/master/me_cleaner.py#L310
The checks are performed by the tool designed for the deblobbing because it's the only tool able to look inside the ME images, and most of the checks are in common. If this is raising suspects, I can split me_cleaner in two.
-
Nicola Corna (Code Review)