Attention is currently required from: Rehan Ghori. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62591 )
Change subject: scout: i2c HID driver for Ilitek touchscreen ......................................................................
Patch Set 1:
(3 comments)
File src/mainboard/google/hatch/variants/scout/gpio.c:
https://review.coreboot.org/c/coreboot/+/62591/comment/d302e16d_2297719f PS1, Line 3: #include <gpio.h> : #include <baseboard/gpio.h> : #include <baseboard/variants.h> : #include <commonlib/helpers.h> : #include <types.h> : #include <soc/gpio.h> : #include <vendorcode/google/chromeos/chromeos.h> nit: please keep alphabetical, i.e.
``` #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <commonlib/helpers.h> #include <gpio.h> #include <soc/gpio.h> #include <types.h> #include <vendorcode/google/chromeos/chromeos.h> ```
File src/mainboard/google/hatch/variants/scout/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/62591/comment/2b15b85b_cd897e1d PS1, Line 389: register "generic.probed" = "1" Are you running with a ChromeOS kernel? If not, then you will not need this, this is for a patch we keep in our local trees (nacked upstream)
https://review.coreboot.org/c/coreboot/+/62591/comment/808c5b75_44fac343 PS1, Line 392: "GPE0_DW0_16 Shouldn't this be `DPE0_DW2_16` ? IIUC, you are trying to refer to GPP_D16 as the wake pin?
DW0 is mapped to A group, DW1 is mapped to C group, DW2 is mapped to the D group, see https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/src...