Change in coreboot[master]: dptf: Add optional support for vendor-specific DPTF ACPI generation
Tim Wawrzynczak has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41892 )
Change subject: dptf: Add optional support for vendor-specific DPTF ACPI generation ......................................................................
dptf: Add optional support for vendor-specific DPTF ACPI generation
Add a few weak, empty vendor_dptf_* methods which can be used to fill in vendor-specific Methods and Names for a DPTF implementation.
BUG=b:143539650 TEST=compiles
Change-Id: I7ecbb9e336acaa11f0149ce71fa264281d77257b Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/drivers/intel/dptf/dptf.c M src/include/acpi/acpigen_dptf.h 2 files changed, 31 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/41892/1
diff --git a/src/drivers/intel/dptf/dptf.c b/src/drivers/intel/dptf/dptf.c index 8c1d8d8..de02433 100644 --- a/src/drivers/intel/dptf/dptf.c +++ b/src/drivers/intel/dptf/dptf.c @@ -100,6 +100,15 @@ } }
+ /* Vendor-specific SSDT generation */ + vendor_dptf_write_dppm_methods(config->policies.enabled.active, tsr_en); + vendor_dptf_write_charger_methods(); + vendor_dptf_write_fan_methods(); + + for (i = 0; i < DPTF_MAX_TSR; ++i) + if (tsr_en[i]) + vendor_dptf_write_thermal_methods(i); + printk(BIOS_INFO, "\_SB.DPTF: %s at %s\n", dev->chip_ops->name, dev_path(dev)); }
@@ -188,3 +197,13 @@ CHIP_NAME("Intel DPTF") .enable_dev = dptf_enable_dev, }; + +/* Weak, empty definitions of vendor_dptf_* functions, to make them optional */ +__weak void vendor_dptf_write_dppm_methods(bool active_policy_enabled, + bool tsr_en[DPTF_MAX_TSR]) { } + +__weak void vendor_dptf_write_charger_methods(void) {} + +__weak void vendor_dptf_write_fan_methods(void) {} + +__weak void vendor_dptf_write_thermal_methods(int tsr_index) {} diff --git a/src/include/acpi/acpigen_dptf.h b/src/include/acpi/acpigen_dptf.h index aa355df..01a64b4 100644 --- a/src/include/acpi/acpigen_dptf.h +++ b/src/include/acpi/acpigen_dptf.h @@ -206,4 +206,16 @@ */ void dptf_write_STA(void);
+/* Optional method for vendor-specific toplevel methods (_SB.DPTF) to be written. */ +void vendor_dptf_write_dppm_methods(bool active_policy_enabled, bool tsr_en[4]); + +/* Optional method for vendor-specific charger (_SB.DPTF.TCHG) methods to be written. */ +void vendor_dptf_write_charger_methods(void); + +/* Optional method for vendor-specific fan methods (_SB.DPTF.TFN1) to be written. */ +void vendor_dptf_write_fan_methods(void); + +/* Optional method for vendor-specific thermal methods (_SB.DPTF.TSRx) to be written. */ +void vendor_dptf_write_thermal_methods(int tsr_index); + #endif /* ACPI_ACPIGEN_DPTF_H */
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41892 )
Change subject: dptf: Add optional support for vendor-specific DPTF ACPI generation ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41892/1/src/drivers/intel/dptf/dptf... File src/drivers/intel/dptf/dptf.c:
https://review.coreboot.org/c/coreboot/+/41892/1/src/drivers/intel/dptf/dptf... PS1, Line 202: __weak void vendor_dptf_write_dppm_methods(bool active_policy_enabled, open brace '{' following function definitions go on the next line
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41892
to look at the new patch set (#2).
Change subject: dptf: Add optional support for vendor-specific DPTF ACPI generation ......................................................................
dptf: Add optional support for vendor-specific DPTF ACPI generation
Add a few weak, empty vendor_dptf_* methods which can be used to fill in vendor-specific Methods and Names for a DPTF implementation.
BUG=b:143539650 TEST=compiles
Change-Id: I7ecbb9e336acaa11f0149ce71fa264281d77257b Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/drivers/intel/dptf/dptf.c M src/include/acpi/acpigen_dptf.h 2 files changed, 39 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/41892/2
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41892
to look at the new patch set (#4).
Change subject: dptf: Add optional support for vendor-specific DPTF ACPI generation ......................................................................
dptf: Add optional support for vendor-specific DPTF ACPI generation
Add a few weak, empty vendor_dptf_* methods which can be used to fill in vendor-specific Methods and Names for a DPTF implementation.
BUG=b:143539650 TEST=compiles
Change-Id: I7ecbb9e336acaa11f0149ce71fa264281d77257b Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/drivers/intel/dptf/dptf.c M src/include/acpi/acpigen_dptf.h 2 files changed, 39 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/41892/4
Hello build bot (Jenkins), Furquan Shaikh, Duncan Laurie, Sumeet R Pawnikar, Subrata Banik, Patrick Rudolph, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41892
to look at the new patch set (#7).
Change subject: dptf: Add optional support for vendor-specific DPTF ACPI generation ......................................................................
dptf: Add optional support for vendor-specific DPTF ACPI generation
Add a few weak, empty vendor_dptf_* methods which can be used to fill in vendor-specific Methods and Names for a DPTF implementation.
BUG=b:143539650 TEST=compiles
Change-Id: I7ecbb9e336acaa11f0149ce71fa264281d77257b Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/drivers/intel/dptf/dptf.c M src/include/acpi/acpigen_dptf.h 2 files changed, 41 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/41892/7
Tim Wawrzynczak has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/41892 )
Change subject: dptf: Add optional support for vendor-specific DPTF ACPI generation ......................................................................
Abandoned
not used anymore, see CB:41894
-
build bot (Jenkins) (Code Review) -
Tim Wawrzynczak (Code Review)