[XS] Change in coreboot[main]: include/device: Fix IO resource handling covering 0xFFFF

[Lean Sheng Tan (Code Review)]

Lean Sheng Tan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/82192?usp=email )

(

1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
 )Change subject: include/device: Fix IO resource handling covering 0xFFFF
......................................................................

include/device: Fix IO resource handling covering 0xFFFF

IO resource creation utils taking 'from' and 'to' as parameters
use uint16_t for them, where 'to' equals the resource limit plus
1. When a resource is with a limit of 0xFFFF, the value of 'to'
will be clipped to 0x0000 by uint16_t. Fix this problem by use
uint32_t and checks the effective range to make sure it no larger
than UINT16_MAX + 1.

TEST=Build and boot on intel/archercity CRB
TEST=Build on intel/avenuecity CRB

Change-Id: Ie83045683094d6330c1676809f83acf30175cc90
Signed-off-by: Shuo Liu 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/82192
Reviewed-by: Angel Pons 
Tested-by: build bot (Jenkins) 
Reviewed-by: Arthur Heymans 
---
M src/include/device/device.h
1 file changed, 6 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, but someone else must approve
  Arthur Heymans: Looks good to me, approved

diff --git a/src/include/device/device.h b/src/include/device/device.h
index 367635a..1b2e097 100644
--- a/src/include/device/device.h
+++ b/src/include/device/device.h
@@ -369,10 +369,12 @@

static inline
 const struct resource *fixed_io_from_to_flags(struct device *dev, unsigned long index,
-				      uint16_t base, uint16_t end, unsigned long flags)
+				      uint16_t base, uint32_t end, unsigned long flags)
 {
    if (end <= base)
    	return NULL;
+	if (end > UINT16_MAX + 1)
+		return NULL;
    return fixed_io_range_flags(dev, index, base, end - base, flags);
 }

@@ -393,10 +395,12 @@

static inline
 const struct resource *domain_io_window_from_to(struct device *dev, unsigned long index,
-				      uint16_t base, uint16_t end)
+				      uint16_t base, uint32_t end)
 {
    if (end <= base)
    	return NULL;
+	if (end > UINT16_MAX + 1)
+		return NULL;
    return domain_io_window_range(dev, index, base, end - base);
 }