Attention is currently required from: Paul Menzel, Mario Scheithauer.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63863 )
Change subject: soc/intel/elkhartlake: Provide ability to update TSN GbE MAC addresses
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
File src/soc/intel/elkhartlake/tsn_gbe.c:
https://review.coreboot.org/c/coreboot/+/63863/comment/b22d9d06_f835fe5a
PS4, Line 8: static void program_mac_address(struct device *dev, uint32_t base)
Since you pass in the device into this function: Would it make sense to let this function get the needed BAR itself? Would de-couple the code a bit more.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63863
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2303a64cfd09fa02734ca9452d26591af2a76221
Gerrit-Change-Number: 63863
Gerrit-PatchSet: 4
Gerrit-Owner: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Comment-Date: Fri, 06 May 2022 06:42:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment