Change in ...coreboot[master]: util/genbuild_h: don't expect `git log` not printing the signature cruft
Sergey Alirzaev has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32129
Change subject: util/genbuild_h: don't expect `git log` not printing the signature cruft ......................................................................
util/genbuild_h: don't expect `git log` not printing the signature cruft
Explicitly ask it not to.
Signed-off-by: Sergey Alirzaev zl29ah@gmail.com Change-Id: I102ecc79bb649a67661c3d22988453dc7741acda --- M util/genbuild_h/genbuild_h.sh 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/32129/1
diff --git a/util/genbuild_h/genbuild_h.sh b/util/genbuild_h/genbuild_h.sh index 340de35..5c45b2b 100755 --- a/util/genbuild_h/genbuild_h.sh +++ b/util/genbuild_h/genbuild_h.sh @@ -27,9 +27,9 @@ TIMESOURCE="fixed" DATE=0 elif [ "$(git rev-parse --is-inside-work-tree 2>/dev/null)" = "true" ]; then - GITREV=$(LANG= git log -1 --format=format:%h) + GITREV=$(LANG= git log --no-show-signature -1 --format=format:%h) TIMESOURCE=git - DATE=$(git log --pretty=format:%ct -1) + DATE=$(git log --no-show-signature --pretty=format:%ct -1) else GITREV=Unknown TIMESOURCE="date"
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32129 )
Change subject: util/genbuild_h: don't expect `git log` not printing the signature cruft ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/32129/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32129/1//COMMIT_MSG@7 PS1, Line 7: util/genbuild_h: don't expect `git log` not printing the signature cruft Please be explicit:
util/genbuild_h: Do not print signature in `git log` output
Hello Paul Menzel, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32129
to look at the new patch set (#2).
Change subject: util/genbuild_h: Do not print PGP verification results in `git log` output ......................................................................
util/genbuild_h: Do not print PGP verification results in `git log` output
Signed-off-by: Sergey Alirzaev zl29ah@gmail.com Change-Id: I102ecc79bb649a67661c3d22988453dc7741acda --- M util/genbuild_h/genbuild_h.sh 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/32129/2
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32129 )
Change subject: util/genbuild_h: Do not print PGP verification results in `git log` output ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32129 )
Change subject: util/genbuild_h: Do not print PGP verification results in `git log` output ......................................................................
util/genbuild_h: Do not print PGP verification results in `git log` output
Signed-off-by: Sergey Alirzaev zl29ah@gmail.com Change-Id: I102ecc79bb649a67661c3d22988453dc7741acda Reviewed-on: https://review.coreboot.org/c/coreboot/+/32129 Reviewed-by: Patrick Georgi pgeorgi@google.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M util/genbuild_h/genbuild_h.sh 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve
diff --git a/util/genbuild_h/genbuild_h.sh b/util/genbuild_h/genbuild_h.sh index 340de35..5c45b2b 100755 --- a/util/genbuild_h/genbuild_h.sh +++ b/util/genbuild_h/genbuild_h.sh @@ -27,9 +27,9 @@ TIMESOURCE="fixed" DATE=0 elif [ "$(git rev-parse --is-inside-work-tree 2>/dev/null)" = "true" ]; then - GITREV=$(LANG= git log -1 --format=format:%h) + GITREV=$(LANG= git log --no-show-signature -1 --format=format:%h) TIMESOURCE=git - DATE=$(git log --pretty=format:%ct -1) + DATE=$(git log --no-show-signature --pretty=format:%ct -1) else GITREV=Unknown TIMESOURCE="date"
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32129 )
Change subject: util/genbuild_h: Do not print PGP verification results in `git log` output ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/32129/3/util/genbuild_h/genbuild_h.sh File util/genbuild_h/genbuild_h.sh:
https://review.coreboot.org/#/c/32129/3/util/genbuild_h/genbuild_h.sh@32 PS3, Line 32: no-show-signature Man...that breaks my old git v2.3.0 as this flag is not available there. In turn, the generated #define in build.h looks now like: #define COREBOOT_VERSION_TIMESTAMP
Which in turn breaks my tree as in src/lib/version.c:32 the compiler is presented an empty assignemnt of the variable: const unsigned int coreboot_version_timestamp = COREBOOT_VERSION_TIMESTAMP;
What was the exact need for this change in the DATE assignment?
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32129 )
Change subject: util/genbuild_h: Do not print PGP verification results in `git log` output ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/32129/3/util/genbuild_h/genbuild_h.sh File util/genbuild_h/genbuild_h.sh:
https://review.coreboot.org/#/c/32129/3/util/genbuild_h/genbuild_h.sh@32 PS3, Line 32: no-show-signature
Man...that breaks my old git v2.3.0 as this flag is not available there. […]
I was able to switch to a newer git version on my machine. So fine for me now though it would be interesting to know what the reason for this change was.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32129 )
Change subject: util/genbuild_h: Do not print PGP verification results in `git log` output ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/32129/3/util/genbuild_h/genbuild_h.sh File util/genbuild_h/genbuild_h.sh:
https://review.coreboot.org/#/c/32129/3/util/genbuild_h/genbuild_h.sh@32 PS3, Line 32: no-show-signature
I was able to switch to a newer git version on my machine. […]
same here :(
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32129 )
Change subject: util/genbuild_h: Do not print PGP verification results in `git log` output ......................................................................
Patch Set 3:
(1 comment)
is there any possibility to revert this CL until we share recommendation to update git version to latest 2.21? my old systems are unable to update to latest git tool.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32129 )
Change subject: util/genbuild_h: Do not print PGP verification results in `git log` output ......................................................................
Patch Set 3:
Patch Set 3:
(1 comment)
is there any possibility to revert this CL until we share recommendation to update git version to latest 2.21? my old systems are unable to update to latest git tool.
Please try https://review.coreboot.org/c/coreboot/+/32299
Sergey Alirzaev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32129 )
Change subject: util/genbuild_h: Do not print PGP verification results in `git log` output ......................................................................
Patch Set 3:
Patch Set 3:
(1 comment)
The purpose of this change is to make the script work in case you have [log] showSignature = true in your ~/.gitconfig.
git-2.3.0 is four years old o_O
-
Patrick Georgi (Code Review) -
Paul Menzel (Code Review)
-
Sergey Alirzaev (Code Review)
-
Subrata Banik (Code Review)
-
Werner Zeh (Code Review)