Attention is currently required from: Philipp Hug, Julius Werner, ron minnich. HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50167 )
Change subject: arch/{arm,riscv}/boot.c: Add missing <commonlib/bsd/cbfs_serialized.h> ......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/50167/comment/95a38d3f_19d7c7e1 PS3, Line 7: arch/{arm,riscv}/boot.c: Add missing <commonlib/bsd/cbfs_serialized.h>
It isn't missing. People use coreboot headers like <cbfs. […]
I think I definitely have a problem with indirect chain-includes. I'll add a comment into 'cbfs.h' explaining that it is supposed to chain-include commonlib headers.
In the other hand and maybe out of topic, I feel like this indirect chain-include is complicated. As an example, 'offsetof' should be defined in <stddef.h>, I finely find it at <commonlib/bsd/helpers.h> ( https://review.coreboot.org/c/coreboot/+/44738/4)