Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42696 )
Change subject: nb/intel/ironlake/northbridge.c: Drop thunk functions ......................................................................
nb/intel/ironlake/northbridge.c: Drop thunk functions
Just call the called function directly.
Change-Id: I0c997a63cbbd2b1029f94c23685847df910f8a0e Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/ironlake/northbridge.c 1 file changed, 2 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/42696/1
diff --git a/src/northbridge/intel/ironlake/northbridge.c b/src/northbridge/intel/ironlake/northbridge.c index f53b03e..267baf7 100644 --- a/src/northbridge/intel/ironlake/northbridge.c +++ b/src/northbridge/intel/ironlake/northbridge.c @@ -147,13 +147,7 @@ add_fixed_resources(dev, 10); }
-static void mc_set_resources(struct device *dev) -{ - /* And call the normal set_resources */ - pci_dev_set_resources(dev); -} - -static void northbridge_dmi_init(struct device *dev) +static void northbridge_init(struct device *dev) { u32 reg32;
@@ -200,11 +194,6 @@ DMIBAR32(0x88) = reg32; }
-static void northbridge_init(struct device *dev) -{ - northbridge_dmi_init(dev); -} - /* Disable unused PEG devices based on devicetree before PCI enumeration */ static void ironlake_init(void *const chip_info) { @@ -229,7 +218,7 @@
static struct device_operations mc_ops = { .read_resources = mc_read_resources, - .set_resources = mc_set_resources, + .set_resources = pci_dev_set_resources, .enable_resources = pci_dev_enable_resources, .init = northbridge_init, .acpi_fill_ssdt = generate_cpu_entries,
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42696 )
Change subject: nb/intel/ironlake/northbridge.c: Drop thunk functions ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42696/1/src/northbridge/intel/ironl... File src/northbridge/intel/ironlake/northbridge.c:
https://review.coreboot.org/c/coreboot/+/42696/1/src/northbridge/intel/ironl... PS1, Line 223: northbridge_init is this still right?
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42696 )
Change subject: nb/intel/ironlake/northbridge.c: Drop thunk functions ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42696/1/src/northbridge/intel/ironl... File src/northbridge/intel/ironlake/northbridge.c:
https://review.coreboot.org/c/coreboot/+/42696/1/src/northbridge/intel/ironl... PS1, Line 223: northbridge_init
is this still right?
Yes, I renamed "northbridge_dmi_init" to "northbridge_init". Should I preserve the old name instead?
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42696 )
Change subject: nb/intel/ironlake/northbridge.c: Drop thunk functions ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/42696/1/src/northbridge/intel/ironl... File src/northbridge/intel/ironlake/northbridge.c:
https://review.coreboot.org/c/coreboot/+/42696/1/src/northbridge/intel/ironl... PS1, Line 223: northbridge_init
Yes, I renamed "northbridge_dmi_init" to "northbridge_init". […]
No, that's alright. I missed the rename and was wondering how this could compile at all ;-)
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42696 )
Change subject: nb/intel/ironlake/northbridge.c: Drop thunk functions ......................................................................
nb/intel/ironlake/northbridge.c: Drop thunk functions
Just call the called function directly.
Change-Id: I0c997a63cbbd2b1029f94c23685847df910f8a0e Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/42696 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M src/northbridge/intel/ironlake/northbridge.c 1 file changed, 2 insertions(+), 13 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/src/northbridge/intel/ironlake/northbridge.c b/src/northbridge/intel/ironlake/northbridge.c index 415c142..6b631b3 100644 --- a/src/northbridge/intel/ironlake/northbridge.c +++ b/src/northbridge/intel/ironlake/northbridge.c @@ -147,13 +147,7 @@ add_fixed_resources(dev, 10); }
-static void mc_set_resources(struct device *dev) -{ - /* And call the normal set_resources */ - pci_dev_set_resources(dev); -} - -static void northbridge_dmi_init(struct device *dev) +static void northbridge_init(struct device *dev) { u32 reg32;
@@ -174,11 +168,6 @@ DMIBAR32(0x88) = reg32; }
-static void northbridge_init(struct device *dev) -{ - northbridge_dmi_init(dev); -} - /* Disable unused PEG devices based on devicetree before PCI enumeration */ static void ironlake_init(void *const chip_info) { @@ -203,7 +192,7 @@
static struct device_operations mc_ops = { .read_resources = mc_read_resources, - .set_resources = mc_set_resources, + .set_resources = pci_dev_set_resources, .enable_resources = pci_dev_enable_resources, .init = northbridge_init, .acpi_fill_ssdt = generate_cpu_entries,
-
Angel Pons (Code Review) -
Patrick Georgi (Code Review)