Attention is currently required from: Reka Norman, Tim Wawrzynczak, Krishna P Bhat D. Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61141 )
Change subject: mb/google/nissa: Add devicetree ......................................................................
Patch Set 6:
(3 comments)
File src/mainboard/google/brya/variants/baseboard/nissa/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/61141/comment/a01d8c2f_fdbfef2d PS5, Line 28:
Port 7 (index 6) is actually used for WFC on nereid. […]
I think WFC won't be a major choice in variants, so prefer to hand it over to variants.
https://review.coreboot.org/c/coreboot/+/61141/comment/7484c77d_00de9c1e PS5, Line 120: i2c0
Can we add the tpm driver here? I think the only reason brya has it in the variants is that some var […]
Yep let's encourage variants not to change i2c bus for the tpm.
https://review.coreboot.org/c/coreboot/+/61141/comment/e6dce3c7_e9b92108 PS5, Line 123: pcie_rp7
Are we supporting RTD3 on the SD card, and if so should we add the RTD3 driver here? On brya, the SD […]
Done
-
Kangheui Won (Code Review)