build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34997 )
Change subject: AGESA,binaryPI: Replace use of __PRE_RAM__ ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34997/1/src/drivers/amd/agesa/def_c... File src/drivers/amd/agesa/def_callouts.c:
https://review.coreboot.org/c/coreboot/+/34997/1/src/drivers/amd/agesa/def_c... PS1, Line 166: return AmdMemoryReadSPD (Func, Data, ConfigPtr); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/34997/1/src/southbridge/amd/cimx/sb... File src/southbridge/amd/cimx/sb900/cfg.c:
https://review.coreboot.org/c/coreboot/+/34997/1/src/southbridge/amd/cimx/sb... PS1, Line 247: if (ENV_RAMSTAGE && !sb_config->StdHeader.CALLBACK.CalloutPtr) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/34997/1/src/southbridge/amd/cimx/sb... PS1, Line 252: printk(BIOS_INFO, "SB900 - Cfg.c - sb900_cimx_config - End.\n"); Prefer using '"%s...", __func__' to using 'sb900_cimx_config', this function's name, in a string
-
build bot (Jenkins) (Code Review)