[M] Change in coreboot[master]: soc/amd: Use common reset code for PCO, CZN, MDN, PHX & Glinda

[Martin L Roth (Code Review)]

Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Fred Reitberger, Felix Held.

Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72659 )

Change subject: soc/amd: Use common reset code for PCO, CZN, MDN, PHX & Glinda
......................................................................

Patch Set 2:

(1 comment)

Patchset:

PS2:
> i'd split this patch into two halves: one for picasso, cezanne and mendocino that doesn't change beh […]

Sure, I can do that. I'd call this a patch to unify the behavior on all the AMD platforms, but it doesn't bother me to split them.

I will say that I've never bought into the idea of "Oh, but what if we have to revert?" though.  That just seems contrived, and things can be modified at that time.  This argument to me is like the "well, we should make this API more flexible in case we need to extend it in the future", which is just poor practice.  If you don't see a requirement to do something right now, do it when it's actually needed.  In this case, if part of it needed to be reverted at some point in the future, just revert the part that's needed instead of the entire patch.  Like with the reset on sabrina, we couldn't revert it because it was renamed in the meantime.  It just doesn't make sense to worry about it right now.