Casper Chang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32988
Change subject: mb/google/sarien: Modify arcada touchscreen reset delay ......................................................................
mb/google/sarien: Modify arcada touchscreen reset delay
Modify reset delay to 20ms of touchscreen to address i2c hid driver rebind failed issue after auto update of touchscreen firmware
BUG=b:132211627 TEST=Touchscreen works after auto update and no re-bind driver failed issue
Change-Id: If17afbd160a2c97beb69d0cb50e4a7dc654775f5 --- M src/mainboard/google/sarien/variants/arcada/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/32988/1
diff --git a/src/mainboard/google/sarien/variants/arcada/devicetree.cb b/src/mainboard/google/sarien/variants/arcada/devicetree.cb index d3848a2..767df1f 100644 --- a/src/mainboard/google/sarien/variants/arcada/devicetree.cb +++ b/src/mainboard/google/sarien/variants/arcada/devicetree.cb @@ -315,7 +315,7 @@ register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_C23_IRQ)" register "generic.probed" = "1" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_E7)" - register "generic.reset_delay_ms" = "10" + register "generic.reset_delay_ms" = "20" register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B21)" register "generic.enable_delay_ms" = "55" register "generic.has_power_resource" = "1"
Hello Duncan Laurie, build bot (Jenkins), Lijian Zhao,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32988
to look at the new patch set (#2).
Change subject: mb/google/sarien: Modify arcada touchscreen reset delay ......................................................................
mb/google/sarien: Modify arcada touchscreen reset delay
Modify reset delay to 20ms of touchscreen to address i2c hid driver rebind failed issue after auto update of touchscreen firmware
BUG=b:132211627 TEST=Touchscreen works after auto update and no re-bind driver failed issue
Signed-off-by: Casper Chang casper_chang@wistron.corp-partner.google.com Change-Id: If17afbd160a2c97beb69d0cb50e4a7dc654775f5 --- M src/mainboard/google/sarien/variants/arcada/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/32988/2
Nick Crews has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32988 )
Change subject: mb/google/sarien: Modify arcada touchscreen reset delay ......................................................................
Patch Set 2: Code-Review+1
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32988 )
Change subject: mb/google/sarien: Modify arcada touchscreen reset delay ......................................................................
Patch Set 2: Code-Review+2
Duncan Laurie has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32988 )
Change subject: mb/google/sarien: Modify arcada touchscreen reset delay ......................................................................
mb/google/sarien: Modify arcada touchscreen reset delay
Modify reset delay to 20ms of touchscreen to address i2c hid driver rebind failed issue after auto update of touchscreen firmware
BUG=b:132211627 TEST=Touchscreen works after auto update and no re-bind driver failed issue
Signed-off-by: Casper Chang casper_chang@wistron.corp-partner.google.com Change-Id: If17afbd160a2c97beb69d0cb50e4a7dc654775f5 Reviewed-on: https://review.coreboot.org/c/coreboot/+/32988 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nick Crews ncrews@chromium.org Reviewed-by: Duncan Laurie dlaurie@chromium.org --- M src/mainboard/google/sarien/variants/arcada/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Duncan Laurie: Looks good to me, approved Nick Crews: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/sarien/variants/arcada/devicetree.cb b/src/mainboard/google/sarien/variants/arcada/devicetree.cb index d3848a2..767df1f 100644 --- a/src/mainboard/google/sarien/variants/arcada/devicetree.cb +++ b/src/mainboard/google/sarien/variants/arcada/devicetree.cb @@ -315,7 +315,7 @@ register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_C23_IRQ)" register "generic.probed" = "1" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_E7)" - register "generic.reset_delay_ms" = "10" + register "generic.reset_delay_ms" = "20" register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B21)" register "generic.enable_delay_ms" = "55" register "generic.has_power_resource" = "1"
-
Casper Chang (Code Review) -
Duncan Laurie (Code Review)
-
Nick Crews (Code Review)