Attention is currently required from: Justin Frodsham, Raul Rangel, Felix Held.
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50242 )
Change subject: vendorcode/amd/fsp/cezanne: add UPD structs from FSP build
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/vendorcode/amd/fsp/cezanne/FspmUpd.h:
https://review.coreboot.org/c/coreboot/+/50242/comment/804d4f55_f7c5fb94
PS1, Line 19: /** Offset 0x0050**/ uint32_t serial_port_baudrate;
: /** Offset 0x0054**/ uint32_t serial_port_refclk;
This is a WIP, if we don't line up the structures, we can't get very far in post. […]
Raul, also FYI that any serial port activity from the FSP will be for debug builds only. But agree that any reconfiguring would be a problem.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50242
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icade1d7bcab7b85cdd25c4114590eb23b914edcd
Gerrit-Change-Number: 50242
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Justin Frodsham
justin.frodsham@amd.corp-partner.google.com
Gerrit-Reviewer: Justin Frodsham
justin.frodsham@protonmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Justin Frodsham
justin.frodsham@amd.corp-partner.google.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Justin Frodsham
justin.frodsham@protonmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 03 Feb 2021 17:37:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Justin Frodsham
justin.frodsham@amd.corp-partner.google.com
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment