Attention is currently required from: Chen Wisley, Tim Wawrzynczak, Paul Menzel.
Keith Tzeng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57671 )
Change subject: driver/i2c/max98390: Add vmon_slot_no/imon_slot_no property
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57671/comment/9da7a634_535426f3
PS1, Line 9: Add two properties (maxim,vmon-slot-no/maxim,imon-slot-no) in maxim9839 driver
Please add a dot/period at the end.
Done
https://review.coreboot.org/c/coreboot/+/57671/comment/fa812265_0ed18241
PS1, Line 9: maxim,vmon-slot-no/maxim,imon-slot-no
Please add a space after the commas.
Done
https://review.coreboot.org/c/coreboot/+/57671/comment/260706fc_25bfd5eb
PS1, Line 10:
https://datasheets.maximintegrated.com/en/ds/MAX98390.pdf […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57671
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idb24d19c7cfea559bf6d53f401d66cadb8b3acc6
Gerrit-Change-Number: 57671
Gerrit-PatchSet: 2
Gerrit-Owner: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anfernee Chen
anfernee_chen@wistron.corp-partner.google.com
Gerrit-CC: Keith Tzeng
keith.tzeng@quanta.corp-partner.google.com
Gerrit-CC: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Attention: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Fri, 17 Sep 2021 10:09:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Keith Tzeng
keith.tzeng@quanta.corp-partner.google.com
Gerrit-MessageType: comment