Attention is currently required from: Felix Singer, Martin L Roth, Jason Nien, Jon Murphy, Martin Roth.
Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72769 )
Change subject: mb/google/skyrim: Disable unused SPI ROM types
......................................................................
Patch Set 3: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/72769/comment/1ba6a83b_5d775019
PS3, Line 10: Excluding the unused ROM types shrinks ramstage by almost 4k.
Nice!
Ack
File src/mainboard/google/skyrim/Kconfig:
https://review.coreboot.org/c/coreboot/+/72769/comment/beb2f6c7_2db109fd
PS3, Line 206: # Gigadevice is used on Whiterun as an alternative to Winbond
: config SPI_FLASH_GIGADEVICE
: default y
:
: # XMC chips used on Markarth as an alternative to Winbond
: # These chips identify as ST Micro (Manufacturer ID: 0x20)
: config SPI_FLASH_STMICRO
: default y
I have converted most of the Google mainboards at the end of 2021 so that selects are done in Kconfi […]
Thanks for the explanation. It sounds like `Kconfig` is the right place for these.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72769
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If6e402269d1f2cac8256d478eb36743441497bdf
Gerrit-Change-Number: 72769
Gerrit-PatchSet: 3
Gerrit-Owner: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Tue, 25 Apr 2023 15:19:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Comment-In-Reply-To: Martin Roth
martin.roth@amd.corp-partner.google.com
Comment-In-Reply-To: Tim Van Patten
timvp@google.com
Gerrit-MessageType: comment