Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45196 )
Change subject: mb/google/dedede: Enable SaGv support ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45196/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45196/4//COMMIT_MSG@7 PS4, Line 7: SaGv support
Does SaGv support depend on mainboard components (e.g. VR), or can it be enabled on any mainboard? […]
It can be enabled for any Mainboard. It is more of SoC specific feature. Can be done, But I find it better to be mainboard controlled . given that some early Si samples might recommend the SaGv to be disabled. In that scenario a board control helps.
https://review.coreboot.org/c/coreboot/+/45196/4//COMMIT_MSG@9 PS4, Line 9:
nit: no space before the comma
Done
https://review.coreboot.org/c/coreboot/+/45196/4//COMMIT_MSG@11 PS4, Line 11:
same here
Done
-
Aamir Bohra (Code Review)