View Change
3 comments:
Commit Message:
Patch Set #4, Line 7: SaGv support
Does SaGv support depend on mainboard components (e.g. VR), or can it be enabled on any mainboard? […]
It can be enabled for any Mainboard. It is more of SoC specific feature. Can be done, But I find it better to be mainboard controlled . given that some early Si samples might recommend the SaGv to be disabled. In that scenario a board control helps.
Patch Set #4, Line 9:
nit: no space before the comma
Done
Patch Set #4, Line 11:
same here
Done
To view, visit change 45196. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0f60aad031ce9dfe23e54426753311c35db46c05
Gerrit-Change-Number: 45196
Gerrit-PatchSet: 5
Gerrit-Owner: Aamir Bohra <aamir.bohra@intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub@google.com>
Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d@intel.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela@intel.com>
Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath@intel.com>
Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar@intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Mon, 12 Oct 2020 05:00:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment