Attention is currently required from: Máté Kukri (mkukri), Angel Pons, Felix Held. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55250 )
Change subject: [WIP] src/superio/smsc: Add support for the SCH5555 ......................................................................
Patch Set 4:
(5 comments)
File src/superio/smsc/sch5555/ramstage.c:
https://review.coreboot.org/c/coreboot/+/55250/comment/63bf85e3_9b5ea238 PS4, Line 145: PNP_MSC0 | PNP_MSC1 same as below
https://review.coreboot.org/c/coreboot/+/55250/comment/706d6cd9_7a36331a PS4, Line 149: PNP_MSC0 is it mandatory to configure this register? if not, drop this for the same reason as below
https://review.coreboot.org/c/coreboot/+/55250/comment/d433aa63_e1ca2e40 PS4, Line 150: PNP_MSC0 | PNP_MSC1 | : PNP_MSC2 | PNP_MSC3 | PNP_MSC4 | PNP_MSC5 drop them, since they are not required. else, coreboot will complain when they are not set in the devicetree
https://review.coreboot.org/c/coreboot/+/55250/comment/52ac6d01_b03d725e PS4, Line 152: PNP_MSC0 | PNP_MSC1 see above and check
File src/superio/smsc/sch5555/sch5555_bootblock.c:
https://review.coreboot.org/c/coreboot/+/55250/comment/257925dc_deeedd91 PS1, Line 2:
early_init.c is usually for code compiled in both bootblock and romstage.
both are "early" ;)
-
Michael Niewöhner (Code Review)