Matt Delco has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41758 )
Change subject: mb/intel/jasperlake_rvp: camera SSDT changes for JSLRVP ......................................................................
Patch Set 8:
(3 comments)
https://review.coreboot.org/c/coreboot/+/41758/1/src/drivers/intel/mipi_came... File src/drivers/intel/mipi_camera/Kconfig:
https://review.coreboot.org/c/coreboot/+/41758/1/src/drivers/intel/mipi_came... PS1, Line 4: y In my past experience I didn't have to make this change. I presume that the driver selection in devicetree overrides this.
https://review.coreboot.org/c/coreboot/+/41758/1/src/mainboard/intel/jasperl... File src/mainboard/intel/jasperlake_rvp/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/41758/1/src/mainboard/intel/jasperl... PS1, Line 50: variant/acpi/camera.asl Should this and the related files be deleted?
https://review.coreboot.org/c/coreboot/+/41758/1/src/mainboard/intel/jasperl... File src/mainboard/intel/jasperlake_rvp/variants/jslrvp/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/41758/1/src/mainboard/intel/jasperl... PS1, Line 439: chip drivers/intel/mipi_camera : register "acpi_uid" = "327680" : register "acpi_name" = ""IPU0"" : register "chip_name" = ""Camera and Imaging Subsystem"" : register "device_type" = "INTEL_ACPI_CAMERA_CIO2" : : register "cio2_num_ports" = "2" : register "cio2_lanes_used[0]" = "2" : register "cio2_lanes_used[1]" = "2" : register "cio2_lane_endpoint[0]" = ""^I2C4.CAM0"" : register "cio2_lane_endpoint[1]" = ""^I2C5.CAM0"" : : device pci 05.0 on end # RP4 : end
Adding IPU0 section under "device pci 05. […]
Normally there'd be a separate CIO device. I'm, not sure if this platform has it elsewhere or combined it with the IPU. E.g.:
https://review.coreboot.org/c/coreboot/+/31164/1/src/mainboard/google/poppy/...
-
Matt Delco (Code Review)