Daniele Forsi (dforsi@gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6272
-gerrit
commit 2940021afafb382e51b61d9692bf3ade5edc6223 Author: Daniele Forsi dforsi@gmail.com Date: Mon Jul 14 15:35:42 2014 +0200
Print fatal error messages to stderr instead of stdout
This uses die() which was previously unused. Before this change an unhelpful error message was printed when make tried to parse English text as if it was part of the makefile: .xcompile:1: *** missing separator (did you mean TAB instead of 8 spaces?). Stop.
After this change the first error message at least mentions that iasl is missing: ERROR: no iasl found make: -print-libgcc-file-name: Command not found make: -print-libgcc-file-name: Command not found make: -print-libgcc-file-name: Command not found /bin/sh: 0: Illegal option - Makefile.inc:36: *** Please use the coreboot toolchain (or prove that your toolchain works). Stop.
Change-Id: I79d5de5993e3828460130192df376daa55f32aa0 Signed-off-by: Daniele Forsi dforsi@gmail.com --- util/xcompile/xcompile | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/util/xcompile/xcompile b/util/xcompile/xcompile index d133bd2..8239243 100644 --- a/util/xcompile/xcompile +++ b/util/xcompile/xcompile @@ -49,8 +49,7 @@ if [ "$(${XGCCPATH}/iasl 2>/dev/null | grep -c ACPI)" -gt 0 ]; then elif [ "$(iasl 2>/dev/null | grep -c ACPI)" -gt 0 ]; then IASL=iasl else - echo "no iasl found" - exit 1 + die "no iasl found" fi
if program_exists gcc; then @@ -58,8 +57,7 @@ if program_exists gcc; then elif program_exists cc; then HOSTCC=cc else - echo "no host compiler found" - exit 1 + die "no host compiler found" fi
cat <<EOF @@ -196,8 +194,7 @@ test_architecture() { if type arch_config_$architecture > /dev/null; then arch_config_$architecture else - echo "no architecture definition for $architecture" - exit 1 + die "no architecture definition for $architecture" fi
# To override toolchain, define CROSS_COMPILE_$arch or CROSS_COMPILE as