HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34260 )
Change subject: soc/intel/fsp_broadwell_de: Correct 'gpio_t' typedef ......................................................................
soc/intel/fsp_broadwell_de: Correct 'gpio_t' typedef
<soc/gpio.h> must typedef a gpio_t that fits in 32 bits.
Change-Id: I62b39a53ad14cefe6e98c772e8a3c4d80dd5d84e Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/intel/fsp_broadwell_de/include/soc/gpio.h 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/34260/1
diff --git a/src/soc/intel/fsp_broadwell_de/include/soc/gpio.h b/src/soc/intel/fsp_broadwell_de/include/soc/gpio.h index 1159d03..6a2d2f2 100644 --- a/src/soc/intel/fsp_broadwell_de/include/soc/gpio.h +++ b/src/soc/intel/fsp_broadwell_de/include/soc/gpio.h @@ -121,7 +121,7 @@
/* Define gpio_t here to be able to use src/include/gpio.h for gpio_set() and gpio_get().*/ -typedef uint8_t gpio_t; +typedef uint32_t gpio_t;
/* Configure GPIOs with mainboard provided settings */ void init_gpios(const struct gpio_config config[]);
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34260 )
Change subject: soc/intel/fsp_broadwell_de: Correct 'gpio_t' typedef ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34260/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34260/1//COMMIT_MSG@9 PS1, Line 9: <soc/gpio.h> must typedef a gpio_t that fits in 32 bits. Why?
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34260 )
Change subject: soc/intel/fsp_broadwell_de: Correct 'gpio_t' typedef ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34260/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34260/1//COMMIT_MSG@9 PS1, Line 9: <soc/gpio.h> must typedef a gpio_t that fits in 32 bits.
Why?
because of line #23 src/include/gpio.h: `_Static_assert(sizeof(gpio_t) <= sizeof(u32), "gpio_t doesn't fit in lb_gpio");`
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34260 )
Change subject: soc/intel/fsp_broadwell_de: Correct 'gpio_t' typedef ......................................................................
Patch Set 1:
gpio_t is not defined at 'src/include/gpio.h' but should be inhere: <soc/gpio.h>
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34260 )
Change subject: soc/intel/fsp_broadwell_de: Correct 'gpio_t' typedef ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34260/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34260/1//COMMIT_MSG@9 PS1, Line 9: <soc/gpio.h> must typedef a gpio_t that fits in 32 bits.
because of line #23 src/include/gpio.h: […]
Sorry, I was wrongly assuming that this isn't to be taken literraly. But if taken literraly, then I have to say: 8 bits fit into 32. So why change anything?
If it wasn't ok, the assertion would use `==` instead of `<=`?
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/34260 )
Change subject: soc/intel/fsp_broadwell_de: Correct 'gpio_t' typedef ......................................................................
Abandoned
-
HAOUAS Elyes (Code Review) -
Nico Huber (Code Review)