[XL] Change in coreboot[main]: soc/mediatek/mt8196: Add RTC driver - coreboot-gerrit

20 Jan 2025


      Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85978?usp=email )
Change subject: soc/mediatek/mt8196: Add RTC driver
......................................................................
Patch Set 5:
(1 comment)
File src/soc/mediatek/mt8196/include/soc/rtc.h:
https://review.coreboot.org/c/coreboot/+/85978/comment/534e56a9_4a73bbdc?usp... :
PS1, Line 18: 	RTC_BBPU_PWREN		= BIT(0),
...
Sorry, but I'm not quite convinced of that approach. […]
@jarried.lin@mediatek.com
I will handle the code refactoring after the patch is merged. Please revert mt6685_hw.h, mt6685_rtc_hw.h to patchset 2 version.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/85978?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3dd337eaa3eed3012ddea300f7e04f2b63fb2daa
Gerrit-Change-Number: 85978
Gerrit-PatchSet: 5
Gerrit-Owner: Jarried Lin jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Shunxi Zhang ot_shunxi.zhang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Yidi Lin yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin hungte@chromium.org
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Jarried Lin jarried.lin@mediatek.com
Gerrit-Comment-Date: Mon, 20 Jan 2025 16:44:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shunxi Zhang ot_shunxi.zhang@mediatek.corp-partner.google.com
Comment-In-Reply-To: Yu-Ping Wu yupingso@google.com