Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Martin L Roth, Nick Vaccaro, Sean Rhodes, Subrata Banik, srinivas.kulkarni@intel.com.
Hello Dinesh Gehlot, Kapil Porwal, Martin L Roth, Nick Vaccaro, Subrata Banik, build bot (Jenkins), srinivas.kulkarni@intel.com,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81080?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: soc/intel/alderlake: Correctly set CNVi Reset and Clkreq pins
......................................................................
soc/intel/alderlake: Correctly set CNVi Reset and Clkreq pins
FSP will default to using GPP_A8 for the reset pin, and GPP_A9 for
the Clkreq. These two pins are reserved for eSPI.
Set these to GPP_F4 and GPP_F5 respectively, as coreboot only supports
eSPI.
Signed-off-by: Sean Rhodes sean@starlabs.systems
Change-Id: Ib534d3cfe888c1c538267caaf324c8ae743da496
---
M src/soc/intel/alderlake/fsp_params.c
1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/81080/5
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81080?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib534d3cfe888c1c538267caaf324c8ae743da496
Gerrit-Change-Number: 81080
Gerrit-PatchSet: 5
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: srinivas.kulkarni@intel.com
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: srinivas.kulkarni@intel.com
Gerrit-MessageType: newpatchset