Change in coreboot[master]: superio/nuvoton: Correct NCT6791D COM A mux toggle

[Angel Pons (Code Review)]

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46521 )

Change subject: superio/nuvoton: Correct NCT6791D COM A mux toggle
......................................................................

superio/nuvoton: Correct NCT6791D COM A mux toggle

Bit 6 of global CR 0x2a toggles the mux for COM B. Bit 7 works just like
on the other two Nuvoton Super I/Os, so fold the conditionals together.

Change-Id: I8cebe35587ae68cac93ed392342662678621efd6
Signed-off-by: Angel Pons 
---
M src/superio/nuvoton/common/early_serial.c
1 file changed, 1 insertion(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/46521/1

diff --git a/src/superio/nuvoton/common/early_serial.c b/src/superio/nuvoton/common/early_serial.c
index ed5fdba..3986789 100644
--- a/src/superio/nuvoton/common/early_serial.c
+++ b/src/superio/nuvoton/common/early_serial.c
@@ -53,14 +53,11 @@
    nuvoton_pnp_enter_conf_state(dev);

if (CONFIG(SUPERIO_NUVOTON_NCT5539D_COM_A) ||
+	    CONFIG(SUPERIO_NUVOTON_NCT6791D_COM_A) ||
        CONFIG(SUPERIO_NUVOTON_NCT6776_COM_A))
    	/* Route COM A to GPIO8 pin group */
    	pnp_unset_and_set_config(dev, 0x2a, 1 << 7, 0);

-	if (CONFIG(SUPERIO_NUVOTON_NCT6791D_COM_A))
-		/* Route COM A to GPIO8 pin group */
-		pnp_write_config(dev, 0x2a, 0x00);
-
    pnp_set_logical_device(dev);
    pnp_set_enable(dev, 0);
    pnp_set_iobase(dev, PNP_IDX_IO0, iobase);

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46521 )

Change subject: superio/nuvoton: Correct NCT6791D COM A mux toggle
......................................................................

Patch Set 1: Code-Review+2

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46521 )

Change subject: superio/nuvoton: Correct NCT6791D COM A mux toggle
......................................................................

Patch Set 1: Code-Review+1

[Michael Niewöhner (Code Review)]

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46521 )

Change subject: superio/nuvoton: Correct NCT6791D COM A mux toggle
......................................................................

Patch Set 1: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46521 )

Change subject: superio/nuvoton: Correct NCT6791D COM A mux toggle
......................................................................

superio/nuvoton: Correct NCT6791D COM A mux toggle

Bit 6 of global CR 0x2a toggles the mux for COM B. Bit 7 works just like
on the other two Nuvoton Super I/Os, so fold the conditionals together.

Change-Id: I8cebe35587ae68cac93ed392342662678621efd6
Signed-off-by: Angel Pons 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/46521
Tested-by: build bot (Jenkins) 
Reviewed-by: Nico Huber 
Reviewed-by: Paul Menzel 
Reviewed-by: Michael Niewöhner 
---
M src/superio/nuvoton/common/early_serial.c
1 file changed, 1 insertion(+), 4 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Nico Huber: Looks good to me, approved
  Paul Menzel: Looks good to me, but someone else must approve
  Michael Niewöhner: Looks good to me, approved

diff --git a/src/superio/nuvoton/common/early_serial.c b/src/superio/nuvoton/common/early_serial.c
index ed5fdba..3986789 100644
--- a/src/superio/nuvoton/common/early_serial.c
+++ b/src/superio/nuvoton/common/early_serial.c
@@ -53,14 +53,11 @@
    nuvoton_pnp_enter_conf_state(dev);

if (CONFIG(SUPERIO_NUVOTON_NCT5539D_COM_A) ||
+	    CONFIG(SUPERIO_NUVOTON_NCT6791D_COM_A) ||
        CONFIG(SUPERIO_NUVOTON_NCT6776_COM_A))
    	/* Route COM A to GPIO8 pin group */
    	pnp_unset_and_set_config(dev, 0x2a, 1 << 7, 0);

-	if (CONFIG(SUPERIO_NUVOTON_NCT6791D_COM_A))
-		/* Route COM A to GPIO8 pin group */
-		pnp_write_config(dev, 0x2a, 0x00);
-
    pnp_set_logical_device(dev);
    pnp_set_enable(dev, 0);
    pnp_set_iobase(dev, PNP_IDX_IO0, iobase);

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46521 )

Change subject: superio/nuvoton: Correct NCT6791D COM A mux toggle
......................................................................

Patch Set 2: Code-Review+2