Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Kangheui Won, Karthik Ramasubramanian, Felix Held.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59867 )
Change subject: mb/google/guybrush: Separate signed amdfw
......................................................................
Patch Set 2:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59867/comment/6ae53064_cd568fb5
PS2, Line 13: which means
: faster boot time
I’d mention the 60 ms here too.
That’s quite some improvement. How big is the AMD firmware? Why does it take so long?
Patchset:
PS2:
It’d be great, if you split the SOC and mainboard changes into separate commits.
File src/soc/amd/cezanne/Kconfig:
https://review.coreboot.org/c/coreboot/+/59867/comment/131b827a_1a48eed4
PS2, Line 464: amd
AMD
https://review.coreboot.org/c/coreboot/+/59867/comment/c774dfad_e8f602f7
PS2, Line 465: them and
Comma after *them*?
https://review.coreboot.org/c/coreboot/+/59867/comment/aed752f5_f688ee3b
PS2, Line 465: rely on AMD's verification
… in PSP?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59867
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If4fd3cff11a38d82afb8c5ce379f1d1b5b9adfbf
Gerrit-Change-Number: 59867
Gerrit-PatchSet: 2
Gerrit-Owner: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 03 Dec 2021 13:27:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment