Change in ...coreboot[master]: [WIP] mb/kontron/bsl6: Add new Skylake COMe module - coreboot-gerrit

15 Jan 2019


      Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29480 )
Change subject: [WIP] mb/kontron/bsl6: Add new Skylake COMe module
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/29480/3/src/mainboard/kontron/bsl6/dsdt.asl 
File src/mainboard/kontron/bsl6/dsdt.asl:
https://review.coreboot.org/#/c/29480/3/src/mainboard/kontron/bsl6/dsdt.asl@... 
PS3, Line 22: 	"COREv4",	// OEM id
            : 	"COREBOOT",	// OEM table id
These should be replaced with the macros in arch/acpi.h (and said header included)
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29480
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If2b6a3f1e9dd095463f1f1521068b9f66a9189c5
Gerrit-Change-Number: 29480
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 15 Jan 2019 14:25:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment