Attention is currently required from: Paul Menzel, Tim Wawrzynczak, Werner Zeh. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63541 )
Change subject: arch/x86/postcar_loader: Correct off-by-one of MTRR end address in log ......................................................................
Patch Set 2: Code-Review-1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63541/comment/b1c15bf1_8ff4de02 PS2, Line 12: wrong It's not wrong. Originally, the start address is inclusive and the end address is exclusive. Your patch makes both start and end addresses inclusive.
Note that this isn't the only place where MTRR ranges are printed this way. At least cpu/x86/mtrr/mtrr.c also prints MTRR ranges where the end address is exclusive. I'd suggest changing all instances of this in the same commit; you can then establish that this is done for consistency (with other MTRR range printing code, as well as allocator resource ranges).
Patchset:
PS2: I don't mind the code change per se, but I don't agree with the reason given in the commit message.