Attention is currently required from: Felix Singer, Iru Cai, Nicholas Chin.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77534?usp=email )
Change subject: ec/dell/mec5035: Add command to enable/disable radios ......................................................................
Patch Set 6:
(3 comments)
File src/ec/dell/mec5035/mec5035.h:
https://review.coreboot.org/c/coreboot/+/77534/comment/9033f4d5_c7b6f708 : PS6, Line 19: EN So is this an Enable, or a toggle? The commit message suggests it might be a toggle.
File src/ec/dell/mec5035/mec5035.c:
https://review.coreboot.org/c/coreboot/+/77534/comment/2083ab95_98b1c6bf : PS6, Line 91: dev The compiler will probably do the right thing here, but it wouldn't hurt to cast this to a u8
https://review.coreboot.org/c/coreboot/+/77534/comment/d7780c9f_3801ad3d : PS6, Line 92: 3 I know the other commands in this file just use bare values, but could this maybe be `sizeof(buf)`? Optionally, you could so something like #define RADIO_EN_CMD_SIZE 3 and use it in both places.