Attention is currently required from: Jeremy Soller. Hello Jeremy Soller,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/50490
to review the following change.
Change subject: ec/system76/ec: Add OLED screen toggle ......................................................................
ec/system76/ec: Add OLED screen toggle
Change-Id: I667accd980da6384a7cc6a3f4eb7565b8b3b2400 Signed-off-by: Jeremy Soller jeremy@system76.com Signed-off-by: Tim Crawford tcrawford@system76.com --- M src/ec/system76/ec/Kconfig M src/ec/system76/ec/acpi/ec.asl M src/ec/system76/ec/acpi/s76.asl 3 files changed, 9 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/50490/1
diff --git a/src/ec/system76/ec/Kconfig b/src/ec/system76/ec/Kconfig index 8c9030e..e9b8091 100644 --- a/src/ec/system76/ec/Kconfig +++ b/src/ec/system76/ec/Kconfig @@ -12,3 +12,8 @@ depends on EC_SYSTEM76_EC bool default n + +config EC_SYSTEM76_EC_OLED + depends on EC_SYSTEM76_EC + bool + default n diff --git a/src/ec/system76/ec/acpi/ec.asl b/src/ec/system76/ec/acpi/ec.asl index 128bd56..3b18e7c 100644 --- a/src/ec/system76/ec/acpi/ec.asl +++ b/src/ec/system76/ec/acpi/ec.asl @@ -97,6 +97,9 @@ Method (_Q0B, 0, NotSerialized) // Screen Toggle { Debug = "EC: Screen Toggle" +#if CONFIG(EC_SYSTEM76_EC_OLED) + Notify (^^^^S76D, 0x85) +#endif // CONFIG(EC_SYSTEM76_EC_OLED) }
Method (_Q0C, 0, NotSerialized) // Mute diff --git a/src/ec/system76/ec/acpi/s76.asl b/src/ec/system76/ec/acpi/s76.asl index a2bb310..62a93ba 100644 --- a/src/ec/system76/ec/acpi/s76.asl +++ b/src/ec/system76/ec/acpi/s76.asl @@ -6,6 +6,7 @@ // 0x82 - backlight down // 0x83 - backlight up // 0x84 - backlight color change +// 0x85 - OLED screen toggle Device (S76D) { Name (_HID, "17761776") Name (_UID, 0)