Attention is currently required from: Felix Singer, Nico Huber, Furquan Shaikh, Subrata Banik, Angel Pons, Michael Niewöhner, Aamir Bohra, Kyösti Mälkki.
Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57721 )
Change subject: soc/intel/cnl: correct gpio GPE mapping for CNP-LP
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Hmhmmmm, this was updated in CB:32175, while my patch here is actually a revert of that... […]
Yes, in that commit I original give a -1 since I thought that's not matching EDS, but after EDS updated and it's correct now. There's case that Intel set to reserved for some definition, but here the program comes to documentation published earlier (002) is not correct, people eventually fix the EDS documentation and make the coreboot code correct as well.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57721
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If529d269ce627f90214a89c4302f2c543a1839fa
Gerrit-Change-Number: 57721
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Wed, 22 Sep 2021 15:05:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment