Aseda Aboagye has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52147 )
Change subject: soc/intel/jasperlake: Move HECI_DISABLE_USING_SMM to mainboards ......................................................................
soc/intel/jasperlake: Move HECI_DISABLE_USING_SMM to mainboards
Some mainboards require HECI to be enabled and having it disabled for all mainboards is problematic. This change simply moves that option to the main boards where it's necessary.
BUG=b:184219504 TEST=Build and flash drawcia, verify that Intel Flash Programming Tool can communicate with the Converged Security Engine.
Signed-off-by: Aseda Aboagye aaboagye@google.com Change-Id: Iced84faaab8a0cca8400ccd3ec6e4cd525c30e92 --- M src/mainboard/google/dedede/Kconfig M src/mainboard/intel/jasperlake_rvp/Kconfig M src/soc/intel/jasperlake/Kconfig 3 files changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/52147/1
diff --git a/src/mainboard/google/dedede/Kconfig b/src/mainboard/google/dedede/Kconfig index 1190e969..513db2d 100644 --- a/src/mainboard/google/dedede/Kconfig +++ b/src/mainboard/google/dedede/Kconfig @@ -35,6 +35,7 @@ select CR50_USE_LONG_INTERRUPT_PULSES select MAINBOARD_HAS_SPI_TPM_CR50 select BOARD_GOOGLE_BASEBOARD_DEDEDE + select HECI_DISABLE_USING_SMM
config BOARD_GOOGLE_BASEBOARD_DEDEDE_TPM2 def_bool n diff --git a/src/mainboard/intel/jasperlake_rvp/Kconfig b/src/mainboard/intel/jasperlake_rvp/Kconfig index 9bd2f5e..16ba324 100644 --- a/src/mainboard/intel/jasperlake_rvp/Kconfig +++ b/src/mainboard/intel/jasperlake_rvp/Kconfig @@ -21,6 +21,7 @@ select SOC_INTEL_JASPERLAKE select SOC_INTEL_COMMON_BLOCK_DTT select SOC_INTEL_CSE_LITE_SKU + select HECI_DISABLE_USING_SMM
config MAINBOARD_DIR string diff --git a/src/soc/intel/jasperlake/Kconfig b/src/soc/intel/jasperlake/Kconfig index 5f37ab1..8d36577 100644 --- a/src/soc/intel/jasperlake/Kconfig +++ b/src/soc/intel/jasperlake/Kconfig @@ -66,7 +66,6 @@ select UDELAY_TSC select UDK_202005_BINDING select DISPLAY_FSP_VERSION_INFO - select HECI_DISABLE_USING_SMM
config DCACHE_RAM_BASE default 0xfef00000