Attention is currently required from: Ravi kumar, Shelley Chen, Martin Roth, Julius Werner. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49768 )
Change subject: sc7280: cpucp loading changes ......................................................................
Patch Set 32:
(42 comments)
File src/soc/qualcomm/sc7280/cpucp_load_reset.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117994): https://review.coreboot.org/c/coreboot/+/49768/comment/651546db_8c0d1479 PS32, Line 15: uint32_t val = read32(EPSSTOP_SECURE_ACCESS_OVERRIDE); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117994): https://review.coreboot.org/c/coreboot/+/49768/comment/c95bdb60_d1c84cd8 PS32, Line 15: uint32_t val = read32(EPSSTOP_SECURE_ACCESS_OVERRIDE); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117994): https://review.coreboot.org/c/coreboot/+/49768/comment/ee878ba0_06fbbda0 PS32, Line 16: val |= 0x1; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117994): https://review.coreboot.org/c/coreboot/+/49768/comment/ac83228e_b04fc691 PS32, Line 16: val |= 0x1; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117994): https://review.coreboot.org/c/coreboot/+/49768/comment/082f5c8c_4ef9254a PS32, Line 18: /* allow NS access to EPSS memory*/ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117994): https://review.coreboot.org/c/coreboot/+/49768/comment/12e283dd_22dccd36 PS32, Line 19: write32(EPSSTOP_SECURE_ACCESS_OVERRIDE, val); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117994): https://review.coreboot.org/c/coreboot/+/49768/comment/63908469_420be76a PS32, Line 19: write32(EPSSTOP_SECURE_ACCESS_OVERRIDE, val); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117994): https://review.coreboot.org/c/coreboot/+/49768/comment/5c94b61a_c21ff14e PS32, Line 21: val = read32(EPSSFAST_EPSS_MUC_CLK_CTRL); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117994): https://review.coreboot.org/c/coreboot/+/49768/comment/7beb25dc_bd1ce6b7 PS32, Line 21: val = read32(EPSSFAST_EPSS_MUC_CLK_CTRL); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117994): https://review.coreboot.org/c/coreboot/+/49768/comment/a7c42aec_8a163c9d PS32, Line 22: val |= 0x1; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117994): https://review.coreboot.org/c/coreboot/+/49768/comment/98636a97_01b8e2cd PS32, Line 22: val |= 0x1; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117994): https://review.coreboot.org/c/coreboot/+/49768/comment/a853124d_734438d8 PS32, Line 24: /* Enable subsystem clock. Required for CPUCP PDMEM access*/ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117994): https://review.coreboot.org/c/coreboot/+/49768/comment/902e5283_20f6e9ce PS32, Line 25: write32(EPSSFAST_EPSS_MUC_CLK_CTRL, val); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117994): https://review.coreboot.org/c/coreboot/+/49768/comment/12b680fd_d3fcb930 PS32, Line 25: write32(EPSSFAST_EPSS_MUC_CLK_CTRL, val); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117994): https://review.coreboot.org/c/coreboot/+/49768/comment/77cf7a28_0aa6c39b PS32, Line 27: while((read32(EPSSFAST_EPSS_MUC_CLK_CTRL) & 0x1) != 0x1); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117994): https://review.coreboot.org/c/coreboot/+/49768/comment/e6bba898_86fecfc1 PS32, Line 27: while((read32(EPSSFAST_EPSS_MUC_CLK_CTRL) & 0x1) != 0x1); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117994): https://review.coreboot.org/c/coreboot/+/49768/comment/35cafc65_f134bef6 PS32, Line 27: while((read32(EPSSFAST_EPSS_MUC_CLK_CTRL) & 0x1) != 0x1); space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117994): https://review.coreboot.org/c/coreboot/+/49768/comment/12359930_1e745993 PS32, Line 27: while((read32(EPSSFAST_EPSS_MUC_CLK_CTRL) & 0x1) != 0x1); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117994): https://review.coreboot.org/c/coreboot/+/49768/comment/99c83710_b7e36860 PS32, Line 32: bool cpucp_fw_entry; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117994): https://review.coreboot.org/c/coreboot/+/49768/comment/edcaf244_ba1c214d PS32, Line 32: bool cpucp_fw_entry; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117994): https://review.coreboot.org/c/coreboot/+/49768/comment/2d437a3b_8c443a96 PS32, Line 33: printk(BIOS_DEBUG, "\nSOC:CPUCP image loading.\n"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117994): https://review.coreboot.org/c/coreboot/+/49768/comment/2c7ec328_dd655a0b PS32, Line 33: printk(BIOS_DEBUG, "\nSOC:CPUCP image loading.\n"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117994): https://review.coreboot.org/c/coreboot/+/49768/comment/419e2411_f704aa7d PS32, Line 35: struct prog cpucp_fw_prog = code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117994): https://review.coreboot.org/c/coreboot/+/49768/comment/0cb9b38a_74da8936 PS32, Line 35: struct prog cpucp_fw_prog = please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117994): https://review.coreboot.org/c/coreboot/+/49768/comment/d96d5d28_9a089290 PS32, Line 36: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/cpucp"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117994): https://review.coreboot.org/c/coreboot/+/49768/comment/275911a2_676958e3 PS32, Line 36: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/cpucp"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117994): https://review.coreboot.org/c/coreboot/+/49768/comment/4917b122_70b1e6f0 PS32, Line 38: cpucp_prepare(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117994): https://review.coreboot.org/c/coreboot/+/49768/comment/c7a1bdb8_2e7ec889 PS32, Line 38: cpucp_prepare(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117994): https://review.coreboot.org/c/coreboot/+/49768/comment/3ea8e48b_5f1c4a0a PS32, Line 40: if (prog_locate(&cpucp_fw_prog)) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117994): https://review.coreboot.org/c/coreboot/+/49768/comment/adea7f85_93faf047 PS32, Line 40: if (prog_locate(&cpucp_fw_prog)) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117994): https://review.coreboot.org/c/coreboot/+/49768/comment/7b996d2c_38932aea PS32, Line 41: die("SOC imagpe: CPUCP_FW not found"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117994): https://review.coreboot.org/c/coreboot/+/49768/comment/65353e6c_e3138338 PS32, Line 41: die("SOC imagpe: CPUCP_FW not found"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117994): https://review.coreboot.org/c/coreboot/+/49768/comment/ce095621_ac6775a6 PS32, Line 43: cpucp_fw_entry = selfload(&cpucp_fw_prog); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117994): https://review.coreboot.org/c/coreboot/+/49768/comment/b6b5cb14_bac3ebcf PS32, Line 43: cpucp_fw_entry = selfload(&cpucp_fw_prog); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117994): https://review.coreboot.org/c/coreboot/+/49768/comment/0c8707bf_719d94b9 PS32, Line 44: if (!cpucp_fw_entry) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117994): https://review.coreboot.org/c/coreboot/+/49768/comment/b41409e1_83ff3959 PS32, Line 44: if (!cpucp_fw_entry) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117994): https://review.coreboot.org/c/coreboot/+/49768/comment/7c5c6b6a_1480e769 PS32, Line 45: die("SOC image: CPUCP load failed"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117994): https://review.coreboot.org/c/coreboot/+/49768/comment/4687b34c_651b1457 PS32, Line 45: die("SOC image: CPUCP load failed"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117994): https://review.coreboot.org/c/coreboot/+/49768/comment/4df2cf33_dfe25101 PS32, Line 47: printk(BIOS_DEBUG, "\nSOC:CPUCP image loaded successfully.\n"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117994): https://review.coreboot.org/c/coreboot/+/49768/comment/48b1c91a_aab85ebd PS32, Line 47: printk(BIOS_DEBUG, "\nSOC:CPUCP image loaded successfully.\n"); please, no spaces at the start of a line
File src/soc/qualcomm/sc7280/soc.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117994): https://review.coreboot.org/c/coreboot/+/49768/comment/39346fa1_9d1535fc PS32, Line 20: REGION_SIZE(dram_cpucp) / KiB); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117994): https://review.coreboot.org/c/coreboot/+/49768/comment/0b1ca0e1_4f596a7b PS32, Line 20: REGION_SIZE(dram_cpucp) / KiB); please, no spaces at the start of a line