Attention is currently required from: YH Lin, Tim Wawrzynczak, Zhuohao Lee, Felix Held.
Raihow Shi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62321 )
Change subject: mb/google/brask/variants/moli: init overridetree for moli
......................................................................
Patch Set 11:
(2 comments)
File src/mainboard/google/brya/variants/moli/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/62321/comment/f78ffff5_e77440d1
PS9, Line 2: field AUDIO 0 2
: option AUDIO_UNKNOWN 0
: option NAU88L25B_I2S 1
: end
Do you have different audio source? If not, i think we can set NAU88L25B_I2S by default.
Ok,I remove it.
https://review.coreboot.org/c/coreboot/+/62321/comment/2f8f2fee_edf89f6c
PS9, Line 58: device ref pcie_rp7 on
: chip drivers/net
: register "wake" = "GPE0_DW0_07"
: register "led_feature" = "0xe0"
: register "customized_led0" = "0x23f"
: register "customized_led2" = "0x028"
: device pci 00.0 on end
: end
: end # RTL8125 Ethernet NIC
It looks like you're using the different lan chip. Please remove or correct this.
The comments #RTL8125 should be modified,I will correct this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62321
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8829d4b39d48ae574eeccbfc62e79b671211ae2d
Gerrit-Change-Number: 62321
Gerrit-PatchSet: 11
Gerrit-Owner: Raihow Shi
raihow_shi@wistron.corp-partner.google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Anfernee Chen
anfernee_chen@wistron.corp-partner.google.com
Gerrit-CC: Ariel Fang
ariel_fang@wistron.corp-partner.google.com
Gerrit-CC: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-CC: Malik Hsu
malik_hsu@wistron.com
Gerrit-CC: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Peter Chi
peter_chi@wistron.corp-partner.google.com
Gerrit-CC: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-CC: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-CC: Will Tsai
will_tsai@wistron.corp-partner.google.com
Gerrit-CC: Zoey Wu
zoey_wu@wistron.corp-partner.google.com
Gerrit-Attention: YH Lin
yueherngl@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 07 Mar 2022 09:10:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Zhuohao Lee
zhuohao@google.com
Gerrit-MessageType: comment