Attention is currently required from: EricR Lai.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59861 )
Change subject: mb/google/brya/var/felwinter: Correct garage wake event
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59861/comment/527e4cc2_e1b95ba0
PS1, Line 9: Eject event is high. Set wake event to active high.
suggestion, add something like:
```
The polarity of the SCI and the wakeup_event_action for the
pen ejection feature were both backwards, and was causing the
system to fail to enter sleep states because the event was
always asserted.
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59861
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I568e9175c7a66599f7a525c32e4def7a79b55a0a
Gerrit-Change-Number: 59861
Gerrit-PatchSet: 1
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: John Su
john_su@compal.corp-partner.google.com
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Fri, 03 Dec 2021 17:44:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment