Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40575 )
Change subject: mb/facebook/watson: add variant watson_v2 ......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40575/8/src/mainboard/facebook/wats... File src/mainboard/facebook/watson/Kconfig:
https://review.coreboot.org/c/coreboot/+/40575/8/src/mainboard/facebook/wats... PS8, Line 58: string
Since this is only valid for v2, it might be cleaner to use "depends on" instead of the if condition […]
Done
https://review.coreboot.org/c/coreboot/+/40575/8/src/mainboard/facebook/wats... File src/mainboard/facebook/watson/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/40575/8/src/mainboard/facebook/wats... PS8, Line 5: : 2nd variant of Watson microserver
no need to put a description here, "Watson_v1" and "Watson_v2" are enough to know they're different […]
Done
-
Jonathan Zhang (Code Review)