Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39570 )
Change subject: drivers/smmstore: default to selected for Tianocore payload ......................................................................
drivers/smmstore: default to selected for Tianocore payload
Now that SMMSTORE is implemented across all platforms that Tianocore supports, default to selected so that NVRAM functions and Tianocore setting saved as users expect.
Change-Id: I067e5faee73cba585a1123215ed2d80e3eaa7877 Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/drivers/smmstore/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/39570/1
diff --git a/src/drivers/smmstore/Kconfig b/src/drivers/smmstore/Kconfig index 333f5e1d..bb90809 100644 --- a/src/drivers/smmstore/Kconfig +++ b/src/drivers/smmstore/Kconfig @@ -13,8 +13,8 @@
config SMMSTORE bool "Support for flash based, SMM mediated data store" - default n depends on BOOT_DEVICE_SUPPORTS_WRITES + default y if PAYLOAD_TIANOCORE select SPI_FLASH_SMM if BOOT_DEVICE_SPI_FLASH_RW_NOMMAP
config SMMSTORE_IN_CBFS
Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39570 )
Change subject: drivers/smmstore: default to selected for Tianocore payload ......................................................................
Patch Set 1: Code-Review+1
This does nothing for UefiPayload, I imagine. Not a problem, I suppose.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39570 )
Change subject: drivers/smmstore: default to selected for Tianocore payload ......................................................................
Patch Set 1:
Patch Set 1: Code-Review+1
This does nothing for UefiPayload, I imagine. Not a problem, I suppose.
could change the condition to CorebootPayloadPkg if that makes more sense
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39570 )
Change subject: drivers/smmstore: default to selected for Tianocore payload ......................................................................
Patch Set 1: Code-Review+2
Patch Set 1:
Patch Set 1: Code-Review+1
This does nothing for UefiPayload, I imagine. Not a problem, I suppose.
could change the condition to CorebootPayloadPkg if that makes more sense
As long as it doesn't break, it's not a big deal
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39570 )
Change subject: drivers/smmstore: default to selected for Tianocore payload ......................................................................
Patch Set 1:
Does CONFIG_SMMSTORE=y correctly compile on all platforms?
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39570 )
Change subject: drivers/smmstore: default to selected for Tianocore payload ......................................................................
drivers/smmstore: default to selected for Tianocore payload
Now that SMMSTORE is implemented across all platforms that Tianocore supports, default to selected so that NVRAM functions and Tianocore setting saved as users expect.
Change-Id: I067e5faee73cba585a1123215ed2d80e3eaa7877 Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/39570 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Benjamin Doron benjamin.doron00@gmail.com Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/drivers/smmstore/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Benjamin Doron: Looks good to me, but someone else must approve
diff --git a/src/drivers/smmstore/Kconfig b/src/drivers/smmstore/Kconfig index 333f5e1d..bb90809 100644 --- a/src/drivers/smmstore/Kconfig +++ b/src/drivers/smmstore/Kconfig @@ -13,8 +13,8 @@
config SMMSTORE bool "Support for flash based, SMM mediated data store" - default n depends on BOOT_DEVICE_SUPPORTS_WRITES + default y if PAYLOAD_TIANOCORE select SPI_FLASH_SMM if BOOT_DEVICE_SPI_FLASH_RW_NOMMAP
config SMMSTORE_IN_CBFS
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
Benjamin Doron (Code Review)
-
Matt DeVillier (Code Review)
-
Patrick Georgi (Code Review)