Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39518 )
Change subject: util/inteltool: add code to dump I2C registers ......................................................................
Patch Set 10:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39518/10/util/inteltool/i2c.c File util/inteltool/i2c.c:
https://review.coreboot.org/c/coreboot/+/39518/10/util/inteltool/i2c.c@4 PS10, Line 4: * Copyright (C) 2008-2010 by coresystems GmbH : * written by Stefan Reinauer stepan@coresystems.de : * Copyright (C) 2017 secunet Security Networks AG : * Copyright (C) 2020 Michael Niewöhner foss@mniewoehner.de since the copyright lines are moved to the AUTHORS file, please remove and add yourself to the authors file if you aren't in there already. probably same for the later patches in this patch train
https://review.coreboot.org/c/coreboot/+/39518/10/util/inteltool/i2c.c@146 PS10, Line 146: size_t i, i2c_cfg_registers_size = 0, i2c_registers_size = 0; i'd prefer the two initializations with 0 on separate lines; at least for me this would slightly improve the readability
https://review.coreboot.org/c/coreboot/+/39518/10/util/inteltool/i2c.c@152 PS10, Line 152: 4 is the number of i2c buses always 4 on all platforms? i'd expect that this also depends on the chipset generation