[XS] Change in coreboot[main]: tests: Allow specifying vboot source directory - coreboot-gerrit

17 Nov 2023


      Attention is currently required from: Martin L Roth.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78849?usp=email )
Change subject: tests: Allow specifying vboot source directory
......................................................................
Patch Set 4:
(1 comment)
File Makefile:
https://review.coreboot.org/c/coreboot/+/78849/comment/85b0bcef_98971a45 :
PS4, Line 18: abspath
The problem with this patch is, when passing an absolute path to `-I`, `vboot-fixup-includes` in security/vboot/Makefile.inc will incorrectly prepend `$(top)` to the include path. While `vboot-fixup-includes` can definitely be fixed, I think it's better to leave `VBOOT_SOURCE` a relative path here. When running unit tests, we can still pass an absolute `VBOOT_SOURCE` to make.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/78849?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id3bb3726c91167d2dd648d748763a3948787f28d
Gerrit-Change-Number: 78849
Gerrit-PatchSet: 4
Gerrit-Owner: Martin L Roth gaumless@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Jakub Czapiga czapiga@google.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Hsuan Ting Chen roccochen@chromium.org
Gerrit-CC: Hsuan-ting Chen roccochen@google.com
Gerrit-Attention: Martin L Roth gaumless@gmail.com
Gerrit-Comment-Date: Fri, 17 Nov 2023 00:30:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment