HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35774 )
Change subject: crossgcc: Upgrade CMake to 3.15.4 ......................................................................
crossgcc: Upgrade CMake to 3.15.4
3.15.4 change: "In CMake 3.15.0 through 3.15.3, the EXCLUDE_FROM_ALL directory property was regressed from pre-3.14 behavior and caused targets within the directory to be excluded even from its own “all”. This has been fixed. The bug also existed in 3.14.0 through 3.14.6 and is fixed in 3.14.7."
Change-Id: Ib564217c4fdcb609fd6dfd4cb71288dd54ffe4bf Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M util/crossgcc/buildgcc D util/crossgcc/sum/cmake-3.15.3.tar.gz.cksum A util/crossgcc/sum/cmake-3.15.4.tar.gz.cksum 3 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/35774/1
diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 9c10c7d..260958c 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -60,7 +60,7 @@ # CLANG version number CLANG_VERSION=8.0.0 MAKE_VERSION=4.2.1 -CMAKE_VERSION=3.15.3 +CMAKE_VERSION=3.15.4 NASM_VERSION=2.14.02
# GCC toolchain archive locations diff --git a/util/crossgcc/sum/cmake-3.15.3.tar.gz.cksum b/util/crossgcc/sum/cmake-3.15.3.tar.gz.cksum deleted file mode 100644 index c467676..0000000 --- a/util/crossgcc/sum/cmake-3.15.3.tar.gz.cksum +++ /dev/null @@ -1 +0,0 @@ -f467388ba336ea3652f5800918a72cfcc4f7f403 tarballs/cmake-3.15.3.tar.gz diff --git a/util/crossgcc/sum/cmake-3.15.4.tar.gz.cksum b/util/crossgcc/sum/cmake-3.15.4.tar.gz.cksum new file mode 100644 index 0000000..9a2571c --- /dev/null +++ b/util/crossgcc/sum/cmake-3.15.4.tar.gz.cksum @@ -0,0 +1 @@ +0bef17d6067df2672edf63d20c8ec9289a82648d tarballs/cmake-3.15.4.tar.gz
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35774
to look at the new patch set (#2).
Change subject: crossgcc: Upgrade CMake to 3.15.5 ......................................................................
crossgcc: Upgrade CMake to 3.15.5
Change-Id: Ib564217c4fdcb609fd6dfd4cb71288dd54ffe4bf Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M util/crossgcc/buildgcc D util/crossgcc/sum/cmake-3.15.3.tar.gz.cksum A util/crossgcc/sum/cmake-3.15.5.tar.gz.cksum 3 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/35774/2
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35774
to look at the new patch set (#3).
Change subject: crossgcc: Upgrade CMake to 3.16.0 ......................................................................
crossgcc: Upgrade CMake to 3.16.0
Change-Id: Ib564217c4fdcb609fd6dfd4cb71288dd54ffe4bf Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M util/crossgcc/buildgcc D util/crossgcc/sum/cmake-3.15.3.tar.gz.cksum A util/crossgcc/sum/cmake-3.16.0.tar.gz.cksum 3 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/35774/3
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35774 )
Change subject: crossgcc: Upgrade CMake to 3.16.0 ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35774 )
Change subject: crossgcc: Upgrade CMake to 3.16.0 ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35774/3/util/crossgcc/buildgcc File util/crossgcc/buildgcc:
https://review.coreboot.org/c/coreboot/+/35774/3/util/crossgcc/buildgcc@85 PS3, Line 85: 3.16 I wonder if that should be v${CMAKE_VERSION_MAJMIN} with CMAKE_VERSION_MAJMIN=$(echo ${CMAKE_VERSION} | cut -d. -f-2), but that's something we could do in a follow up commit.
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35774 )
Change subject: crossgcc: Upgrade CMake to 3.16.0 ......................................................................
crossgcc: Upgrade CMake to 3.16.0
Change-Id: Ib564217c4fdcb609fd6dfd4cb71288dd54ffe4bf Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/35774 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M util/crossgcc/buildgcc D util/crossgcc/sum/cmake-3.15.3.tar.gz.cksum A util/crossgcc/sum/cmake-3.16.0.tar.gz.cksum 3 files changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 806b6c0..b78637a 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -60,7 +60,7 @@ # CLANG version number CLANG_VERSION=8.0.0 MAKE_VERSION=4.2.1 -CMAKE_VERSION=3.15.3 +CMAKE_VERSION=3.16.0 NASM_VERSION=2.14.02
# GCC toolchain archive locations @@ -82,7 +82,7 @@ CRT_ARCHIVE="https://releases.llvm.org/$%7BCLANG_VERSION%7D/compiler-rt-$%7BCLANG_VERSION..." CTE_ARCHIVE="https://releases.llvm.org/$%7BCLANG_VERSION%7D/clang-tools-extra-$%7BCLANG_V..." MAKE_ARCHIVE="https://ftpmirror.gnu.org/make/make-$%7BMAKE_VERSION%7D.tar.bz2" -CMAKE_ARCHIVE="https://cmake.org/files/v3.15/cmake-$%7BCMAKE_VERSION%7D.tar.gz" +CMAKE_ARCHIVE="https://cmake.org/files/v3.16/cmake-$%7BCMAKE_VERSION%7D.tar.gz" NASM_ARCHIVE="https://www.nasm.us/pub/nasm/releasebuilds/$%7BNASM_VERSION%7D/nasm-$%7BNASM..."
ALL_ARCHIVES="$GMP_ARCHIVE $MPFR_ARCHIVE $MPC_ARCHIVE \ diff --git a/util/crossgcc/sum/cmake-3.15.3.tar.gz.cksum b/util/crossgcc/sum/cmake-3.15.3.tar.gz.cksum deleted file mode 100644 index c467676..0000000 --- a/util/crossgcc/sum/cmake-3.15.3.tar.gz.cksum +++ /dev/null @@ -1 +0,0 @@ -f467388ba336ea3652f5800918a72cfcc4f7f403 tarballs/cmake-3.15.3.tar.gz diff --git a/util/crossgcc/sum/cmake-3.16.0.tar.gz.cksum b/util/crossgcc/sum/cmake-3.16.0.tar.gz.cksum new file mode 100644 index 0000000..0adcc1a --- /dev/null +++ b/util/crossgcc/sum/cmake-3.16.0.tar.gz.cksum @@ -0,0 +1 @@ +9943ebbbf076bbe1b54c7dadcd6df28ad0d241ed tarballs/cmake-3.16.0.tar.gz
-
HAOUAS Elyes (Code Review) -
Patrick Georgi (Code Review)