Elyes Haouas has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81431?usp=email )
Change subject: superio: Remove blank lines before and after code blocks ......................................................................
superio: Remove blank lines before and after code blocks
Change-Id: I0d2ff9828e83ef927036c561d11f95b54b858cda Signed-off-by: Elyes Haouas ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/81431 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@mailbox.org Reviewed-by: Eric Lai ericllai@google.com --- M src/superio/common/conf_mode.c M src/superio/common/generic.c M src/superio/common/ssdt.c M src/superio/fintek/f71808a/chip.h M src/superio/fintek/f81803a/superio.c M src/superio/fintek/f81865f/superio.c M src/superio/fintek/f81866d/chip.h M src/superio/ite/it8712f/superio.c M src/superio/ite/it8721f/superio.c M src/superio/nuvoton/wpcm450/superio.c M src/superio/renesas/m3885x/superio.c M src/superio/smsc/lpc47m15x/superio.c M src/superio/smsc/lpc47n227/superio.c M src/superio/smsc/mec1308/superio.c M src/superio/smsc/smscsuperio/superio.c M src/superio/winbond/w83627dhg/superio.c M src/superio/winbond/w83627thg/superio.c M src/superio/winbond/w83627uhg/superio.c M src/superio/winbond/w83977tf/superio.c 19 files changed, 0 insertions(+), 21 deletions(-)
Approvals: Eric Lai: Looks good to me, approved build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve
diff --git a/src/superio/common/conf_mode.c b/src/superio/common/conf_mode.c index 0978042..6100b4a 100644 --- a/src/superio/common/conf_mode.c +++ b/src/superio/common/conf_mode.c @@ -115,7 +115,6 @@ acpigen_write_store(); acpigen_write_byte(0xa0); acpigen_emit_namestring(idx); - }
static void pnp_ssdt_enter_conf_mode_a5a5(struct device *dev, const char *idx, const char *data) @@ -161,7 +160,6 @@
static void pnp_ssdt_exit_conf_mode_0202(struct device *dev, const char *idx, const char *data) { - acpigen_write_store(); acpigen_write_byte(0x02); acpigen_emit_namestring(idx); diff --git a/src/superio/common/generic.c b/src/superio/common/generic.c index 92d8357..e4d0e7b 100644 --- a/src/superio/common/generic.c +++ b/src/superio/common/generic.c @@ -320,7 +320,6 @@ printk(BIOS_ERR, "%s: Base address not set\n", dev_path(dev)); else dev->ops = &ops; - }
struct chip_operations superio_common_ops = { diff --git a/src/superio/common/ssdt.c b/src/superio/common/ssdt.c index fd55792..4fd1eed 100644 --- a/src/superio/common/ssdt.c +++ b/src/superio/common/ssdt.c @@ -103,7 +103,6 @@ } if (irq) acpigen_write_irq(irq); - }
/* Add resource base and size for additional SuperIO code */ @@ -225,7 +224,6 @@
acpigen_emit_byte(RETURN_OP); acpigen_emit_byte(LOCAL0_OP); - } acpigen_pop_len(); /* Method */
diff --git a/src/superio/fintek/f71808a/chip.h b/src/superio/fintek/f71808a/chip.h index a1ee597..6a41f88 100644 --- a/src/superio/fintek/f71808a/chip.h +++ b/src/superio/fintek/f71808a/chip.h @@ -6,7 +6,6 @@ #include <stdint.h>
struct superio_fintek_f71808a_config { - uint8_t hwm_vt1_boundary_1_temperature; uint8_t hwm_vt1_boundary_2_temperature; uint8_t hwm_vt1_boundary_3_temperature; diff --git a/src/superio/fintek/f81803a/superio.c b/src/superio/fintek/f81803a/superio.c index 4d4e8bc..0975bec 100644 --- a/src/superio/fintek/f81803a/superio.c +++ b/src/superio/fintek/f81803a/superio.c @@ -29,7 +29,6 @@ f81803a_pme_init(dev); break; } - }
static struct device_operations ops = { diff --git a/src/superio/fintek/f81865f/superio.c b/src/superio/fintek/f81865f/superio.c index 70fefe5..8ca66a0 100644 --- a/src/superio/fintek/f81865f/superio.c +++ b/src/superio/fintek/f81865f/superio.c @@ -9,7 +9,6 @@
static void f81865f_init(struct device *dev) { - if (!dev->enabled) return;
diff --git a/src/superio/fintek/f81866d/chip.h b/src/superio/fintek/f81866d/chip.h index 14b79ee..c5c8d76 100644 --- a/src/superio/fintek/f81866d/chip.h +++ b/src/superio/fintek/f81866d/chip.h @@ -6,7 +6,6 @@ #include <stdint.h>
struct superio_fintek_f81866d_config { - /* AMD TSI */ uint8_t hwm_amd_tsi_addr; uint8_t hwm_amd_tsi_control; diff --git a/src/superio/ite/it8712f/superio.c b/src/superio/ite/it8712f/superio.c index 03127b5..119a38c 100644 --- a/src/superio/ite/it8712f/superio.c +++ b/src/superio/ite/it8712f/superio.c @@ -9,7 +9,6 @@
static void it8712f_init(struct device *dev) { - if (!dev->enabled) return;
diff --git a/src/superio/ite/it8721f/superio.c b/src/superio/ite/it8721f/superio.c index 801e27b..eb7f2ee 100644 --- a/src/superio/ite/it8721f/superio.c +++ b/src/superio/ite/it8721f/superio.c @@ -9,7 +9,6 @@
static void init(struct device *dev) { - if (!dev->enabled) return;
diff --git a/src/superio/nuvoton/wpcm450/superio.c b/src/superio/nuvoton/wpcm450/superio.c index 863ad2b..7d79a3f 100644 --- a/src/superio/nuvoton/wpcm450/superio.c +++ b/src/superio/nuvoton/wpcm450/superio.c @@ -8,7 +8,6 @@
static void init(struct device *dev) { - if (!dev->enabled) return;
diff --git a/src/superio/renesas/m3885x/superio.c b/src/superio/renesas/m3885x/superio.c index 6b71256..45bc750 100644 --- a/src/superio/renesas/m3885x/superio.c +++ b/src/superio/renesas/m3885x/superio.c @@ -9,7 +9,6 @@
static void m3885x_init(struct device *dev) { - if (!dev->enabled) return;
diff --git a/src/superio/smsc/lpc47m15x/superio.c b/src/superio/smsc/lpc47m15x/superio.c index 6f57133..8cba7bbe 100644 --- a/src/superio/smsc/lpc47m15x/superio.c +++ b/src/superio/smsc/lpc47m15x/superio.c @@ -43,7 +43,6 @@
static void lpc47m15x_init(struct device *dev) { - if (!dev->enabled) return;
diff --git a/src/superio/smsc/lpc47n227/superio.c b/src/superio/smsc/lpc47n227/superio.c index edcc271..172084f 100644 --- a/src/superio/smsc/lpc47n227/superio.c +++ b/src/superio/smsc/lpc47n227/superio.c @@ -106,7 +106,6 @@ */ static void lpc47n227_init(struct device *dev) { - if (!dev->enabled) return;
diff --git a/src/superio/smsc/mec1308/superio.c b/src/superio/smsc/mec1308/superio.c index 39e100e..83060cc 100644 --- a/src/superio/smsc/mec1308/superio.c +++ b/src/superio/smsc/mec1308/superio.c @@ -11,7 +11,6 @@
static void mec1308_init(struct device *dev) { - if (!dev->enabled) return;
diff --git a/src/superio/smsc/smscsuperio/superio.c b/src/superio/smsc/smscsuperio/superio.c index 3ba8216..d9aa477 100644 --- a/src/superio/smsc/smscsuperio/superio.c +++ b/src/superio/smsc/smscsuperio/superio.c @@ -216,7 +216,6 @@ u8 test7;
if (first_time) { - pnp_enter_conf_mode_55(dev);
/* Read the device ID and revision of the Super I/O chip. */ diff --git a/src/superio/winbond/w83627dhg/superio.c b/src/superio/winbond/w83627dhg/superio.c index 491b5c9..d1df983 100644 --- a/src/superio/winbond/w83627dhg/superio.c +++ b/src/superio/winbond/w83627dhg/superio.c @@ -20,7 +20,6 @@
static void w83627dhg_init(struct device *dev) { - if (!dev->enabled) return;
diff --git a/src/superio/winbond/w83627thg/superio.c b/src/superio/winbond/w83627thg/superio.c index 156239f..7778a28 100644 --- a/src/superio/winbond/w83627thg/superio.c +++ b/src/superio/winbond/w83627thg/superio.c @@ -8,7 +8,6 @@
static void w83627thg_init(struct device *dev) { - if (!dev->enabled) return;
diff --git a/src/superio/winbond/w83627uhg/superio.c b/src/superio/winbond/w83627uhg/superio.c index e276fc5..3098ee2 100644 --- a/src/superio/winbond/w83627uhg/superio.c +++ b/src/superio/winbond/w83627uhg/superio.c @@ -38,7 +38,6 @@
static void w83627uhg_init(struct device *dev) { - if (!dev->enabled) return;
diff --git a/src/superio/winbond/w83977tf/superio.c b/src/superio/winbond/w83977tf/superio.c index 28bfc8c..04530ab 100644 --- a/src/superio/winbond/w83977tf/superio.c +++ b/src/superio/winbond/w83977tf/superio.c @@ -9,7 +9,6 @@
static void w83977tf_init(struct device *dev) { - if (!dev->enabled) return;
-
Elyes Haouas (Code Review)