Daniel Maslowski has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33009
Change subject: superio/smsc/smscsuperio: Add SCH5317 ......................................................................
superio/smsc/smscsuperio: Add SCH5317
According to the Linux kernel docs (Documentation/hwmon/smsc47b397), this EC is compatible with the SMSC LPC47B397-NC. No public datasheet is available.
Found on a Gigabyte P34V2 board.
Change-Id: Ib3227213f6a0fe4a02c5f53471f67089a8e5b4be Signed-off-by: Daniel Maslowski dan@orangecms.org --- M src/superio/smsc/smscsuperio/superio.c 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/33009/1
diff --git a/src/superio/smsc/smscsuperio/superio.c b/src/superio/smsc/smscsuperio/superio.c index 4ce006d..523bcc1 100644 --- a/src/superio/smsc/smscsuperio/superio.c +++ b/src/superio/smsc/smscsuperio/superio.c @@ -56,6 +56,7 @@ #define SCH3112 0x7c #define SCH3114 0x7d #define SCH5307 0x81 /* Rebranded LPC47B397(?) */ +#define SCH5317 0x85 /* compatible with LPC47B397 */ #define SCH5027D 0x89 #define SCH4304 0x90 /* SCH4304, SCH4307 */ #define SCH5147 0xc1 @@ -136,6 +137,7 @@ {SCH3112, {0, 3, 4, 5, -1, 7, -1, -1, -1, -1, -1, -1, 10, -1, -1}}, {SCH3114, {0, 3, 4, 5, -1, 7, -1, -1, -1, -1, -1, -1, 10, -1, -1}}, {SCH5307, {0, 3, 4, 5, -1, 7, -1, -1, 8, -1, -1, -1, 10, -1, -1}}, + {SCH5317, {0, 3, 4, 5, -1, 7, -1, -1, 8, -1, -1, -1, 10, -1, -1}}, // TODO: check correctness {SCH5027D, {0, 3, 4, 5, -1, 7, -1, -1, -1, -1, -1, -1, 10, -1, 11}}, {SCH4304, {0, 3, 4, 5, -1, 7, -1, 11, -1, -1, -1, -1, 10, -1, -1}}, {SCH5147, {0, 3, 4, 5, -1, 7, -1, -1, -1, -1, -1, -1, 10, -1, -1}},
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33009 )
Change subject: superio/smsc/smscsuperio: Add SCH5317 ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/33009/1/src/superio/smsc/smscsuperio/superio... File src/superio/smsc/smscsuperio/superio.c:
https://review.coreboot.org/#/c/33009/1/src/superio/smsc/smscsuperio/superio... PS1, Line 140: {SCH5317, {0, 3, 4, 5, -1, 7, -1, -1, 8, -1, -1, -1, 10, -1, -1}}, // TODO: check correctness line over 80 characters
https://review.coreboot.org/#/c/33009/1/src/superio/smsc/smscsuperio/superio... PS1, Line 140: {SCH5317, {0, 3, 4, 5, -1, 7, -1, -1, 8, -1, -1, -1, 10, -1, -1}}, // TODO: check correctness space required after that close brace '}'
Stefan Reinauer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/33009?usp=email )
Change subject: superio/smsc/smscsuperio: Add SCH5317 ......................................................................
Abandoned
-
build bot (Jenkins) (Code Review) -
Daniel Maslowski (Code Review)
-
Stefan Reinauer (Code Review)