Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Angel Pons, Arthur Heymans, Patrick Rudolph, Felix Held.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51634 )
Change subject: device/azalia_device.c: Unify `wait_for_valid` timeouts
......................................................................
Patch Set 5: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51634/comment/56f94b9e_8734c908
PS5, Line 16: 25 ms
us ?
File src/device/azalia_device.c:
https://review.coreboot.org/c/coreboot/+/51634/comment/fcf49c7f_00b21ca8
PS5, Line 185: * use a reasonably long enough timeout to cover all possible cases.
Personally, I'd keep the reasoning to the commit message. It applies to
most timeouts, should they all have such a comment? What is specific to
this code is that we bail out properly (not everyone handles errors that
gracefully).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51634
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia5e4829d404dcecdb9e7a377e896a319cb38531a
Gerrit-Change-Number: 51634
Gerrit-PatchSet: 5
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 22 Mar 2021 19:03:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment