Attention is currently required from: Subrata Banik, Sridhar Siricilla, Nick Vaccaro.
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69189 )
Change subject: soc/intel/common/block/pcie/rtd3: Skip Power On if _STA returns 1
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Do you know where we are setting the _STA for RTD3 power resource to `1`? […]
this function pcie_rtd3_acpi_method_status will create below acpi code
it will return 1 if power pin is up
Method (_STA, 0, NotSerialized) // _STA: Status
{
0x6E = _SB.PCI0.GTXS /* External reference */
Local0
Local1 = Zero
If ((Local0 == Local1))
{
Return (Zero)
}
Else
{
Return (One)
}
}
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69189
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I296ce1b85417a5dbaca558511cd7fc51a3a38c84
Gerrit-Change-Number: 69189
Gerrit-PatchSet: 2
Gerrit-Owner: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kane Chen
kane.chen@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Fri, 04 Nov 2022 07:32:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment