Change in coreboot[master]: soc/mediatek/mt8186: Add GPIO drivers - coreboot-gerrit

2 Nov 2021


      Attention is currently required from: Hung-Te Lin, Yu-Ping Wu.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58836 )
Change subject: soc/mediatek/mt8186: Add GPIO drivers
......................................................................
Patch Set 1:
(1 comment)
File src/soc/mediatek/mt8186/include/soc/gpio.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131964):
https://review.coreboot.org/c/coreboot/+/58836/comment/25edfbd2_4066f51b 
PS1, Line 21: #define PIN(id, name, flag, bit, base, offset, \
Macros with complex values should be enclosed in parentheses
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/58836
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ice342ab94397db8bc0fbbeb8fb5ee7e19de871ee
Gerrit-Change-Number: 58836
Gerrit-PatchSet: 1
Gerrit-Owner: Rex-BC Chen rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin hungte@chromium.org
Gerrit-Attention: Yu-Ping Wu yupingso@google.com
Gerrit-Comment-Date: Tue, 02 Nov 2021 05:49:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment