Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40475 )
Change subject: device: Add checks for NULL in device_const.c functions ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40475/3/src/device/device_const.c File src/device/device_const.c:
https://review.coreboot.org/c/coreboot/+/40475/3/src/device/device_const.c@8... PS3, Line 89: if (!path1 || !path2)
I changed it to add assert and get rid of the individual print messages.
See latest patchset
https://review.coreboot.org/c/coreboot/+/40475/5/src/device/device_const.c File src/device/device_const.c:
https://review.coreboot.org/c/coreboot/+/40475/5/src/device/device_const.c@9... PS5, Line 91: assert(0); With this, it's still impossible to tell which path is null. Maybe use:
assert(path1); assert(path2);