Sugnan Prabhu S has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41624 )
Change subject: drivers/intel/mipi_camera: SSDT add camera power resource ......................................................................
Patch Set 22:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41624/18/src/drivers/intel/mipi_cam... File src/drivers/intel/mipi_camera/chip.h:
https://review.coreboot.org/c/coreboot/+/41624/18/src/drivers/intel/mipi_cam... PS18, Line 189: const char *pr0; : const char *pr3;
You can emit the PowerResource "inside" of the Device's scope, hence no name collisions, and it can […]
I have made this changes, waiting on the test results before I push the changes.
https://review.coreboot.org/c/coreboot/+/41624/16/src/drivers/intel/mipi_cam... File src/drivers/intel/mipi_camera/chip.h:
https://review.coreboot.org/c/coreboot/+/41624/16/src/drivers/intel/mipi_cam... PS16, Line 185: const char *pr3;
IMO coreboot should be like other firmwares and not have a PR3 (or at least have a non-empty PR3) si […]
@Matt I have made the changes to remove PR3, I will be pushing the changes as part of next CL. Changes were made to print some debug logs on calling PR3 resource and did not see the prints on powering off and turning on camera from sysfs.
-
Sugnan Prabhu S (Code Review)